Repository navigation
fix: resolve known-good versions to verified commits - #111
Merged
Merged
Conversation
a-zw
previously requested changes
Sep 30, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation safely handles unresolved refs and the regression test covers the intended fallback behavior.
Review effort: Balanced
Findings: None
What changed in this PR
This PR makes known-good version resolution resilient by verifying GitHub refs before comparison and falling back to v-prefixed tags.
Changes:
- Force completion of lazy PyGithub commits to validate refs.
- Retry unresolved versions with a
vprefix. - Add regression coverage for fallback resolution.
| File | Description |
|---|---|
src/generate_repo_overview/collector/reference_integration.py |
Verifies version refs and returns the resolved commit SHA. |
tests/test_repo_overview.py |
Tests rejection of a plain version and successful prefixed-tag fallback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MaximilianSoerenPollak
approved these changes
Sep 30, 2026
AlexanderLanin
dismissed
a-zw’s stale review
September 30, 2026 12:41
not critical tool, merging as-is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this makes possible
The scheduled repository overview and Pages refresh can complete even when a Bazel module version in
known_good.jsondoes not directly match a GitHub ref. The overview can still compare the pinned module version with the repository's main branch whenever GitHub can resolve that version to a commit.Why this matters
A single unresolved version currently aborts collection for the whole organization. That leaves the generated profile and repository metrics out of date until a later run succeeds.
Changes
v-prefixed form when the unprefixed version cannot be resolved.