Repository navigation
Added serialization infrastructure - #1397
Draft
Tejaswini-Janjale25 wants to merge 1 commit into
Draft
Tejaswini-Janjale25 wants to merge 1 commit into
Tejaswini-Janjale25 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| std::fprintf(file, "%s\n", marker); |
mseth77
reviewed
Oct 19, 2026
| SerializationInfrastructure(SerializationInfrastructure&&) = delete; | ||
| SerializationInfrastructure& operator=(SerializationInfrastructure&&) = delete; | ||
|
|
||
| bool IsOpen() const noexcept; |
Contributor
Author
There was a problem hiding this comment.
I have updated the code
mseth77
reviewed
Oct 19, 2026
| SerializationInfrastructure& operator=(SerializationInfrastructure&&) = delete; | ||
|
|
||
| bool IsOpen() const noexcept; | ||
| const std::string& ErrorMessage() const noexcept; |
There was a problem hiding this comment.
Get rid of Error message. Use Result as a return.
Contributor
Author
There was a problem hiding this comment.
I have updated it
mseth77
reviewed
Oct 19, 2026
|
|
||
| const auto probe_value = infrastructure.ResolveSymbol<BackendProbeValueFn>("BackendProbeValue"); | ||
| ASSERT_NE(probe_value, nullptr) << infrastructure.ErrorMessage(); | ||
| EXPECT_EQ(probe_value(), 0xC0FFEE42U); |
Contributor
Author
There was a problem hiding this comment.
I have updated it
mseth77
reviewed
Oct 19, 2026
| constexpr const char* kLifecycleFileEnv = "SERIALIZER_BACKEND_LIFECYCLE_FILE"; | ||
| constexpr const char* kTestPluginRunfile = | ||
| "score_communication/score/mw/com/impl/serialization/serialization_infrastructure_test_plugin.so"; | ||
|
|
There was a problem hiding this comment.
As I remember dfcnlImpl provides a way to inject mocks.
Please rewrite the test using Mocks.
For reference look at Flock test in the mw::com repo.
Contributor
Author
There was a problem hiding this comment.
I have updated the tests
Introduce shared serializer loading infrastructure under score/mw/com/impl/serialization using score::os dynamic loading, with supporting BUILD and integration test files. SWP-279540
Tejaswini-Janjale25
force-pushed
the
teja_serializer_infrastructure
branch
from
October 21, 2026 11:08
4575288 to
9d2f6bd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce shared serializer loading infrastructure under score/mw/com/impl/serialization using score::os dynamic loading, with supporting BUILD and integration test files. SWP-279540