Repository navigation
fix(codeql): remove non-literal constexpr lambda return type - #1402
Open
SlimyoAfricanus wants to merge 1 commit into
Open
SlimyoAfricanus wants to merge 1 commit into
SlimyoAfricanus wants to merge 1 commit into
Conversation
The lambda in GetNumberOfTracingSlots() was marked constexpr while returning EventInstanceMapping/FieldInstanceMapping (std::unordered_map based types), which are non-literal types and cannot be the return type of a constexpr function. The qualifier was unnecessary since the if constexpr branches inside already resolve based on the template parameter regardless of the lambda's own constexpr-ness.
bemerybmw
approved these changes
Oct 16, 2026
bemerybmw
marked this pull request as ready for review
October 16, 2026 13:42
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
October 16, 2026 13:42
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lambda in
GetNumberOfTracingSlots()was markedconstexprwhile returningEventInstanceMapping/FieldInstanceMapping(std::unordered_map-based types), which are non-literal types and cannot be the return type of a constexpr function. The qualifier was unnecessary since theif constexprbranches inside already resolve based on the template parameter regardless of the lambda's own constexpr-ness. This clears 2 of the 3 recoverable extraction errors in the CodeQL database integrity report.