Repository navigation
refactor(tools): read setup metadata through the shared catalog - #203
Merged
lurtz merged 1 commit intoNov 6, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change centralizing setup metadata preparation in the shared catalog reader.
No open issues 🎉
What changed in this PR
Moves setup metadata preparation into the shared catalog reader, continuing the separation of metadata access from installation logic. Existing shell exports and installation behavior are preserved.
Changes:
- Add
catalog.load_setup_metadata()and use it for setup environments andshell-metadata. - Move the version metadata assertion from installer tests to catalog tests.
- Document the boundary between metadata preparation and installer responsibilities.
| File | Description |
|---|---|
tools/tests/environment_test.py |
Remove the metadata assertion moved to catalog tests. |
tools/tests/catalog_test.py |
Verify command versions through the shared metadata reader. |
tools/internal/README.md |
Document setup metadata ownership and installer responsibilities. |
tools/internal/devcontainer/install.py |
Replace local metadata preparation with the shared reader. |
tools/internal/catalog.py |
Add the extracted setup metadata preparation function. |
Review effort: Balanced
AlexanderLanin
marked this pull request as ready for review
November 5, 2026 19:24
AlexanderLanin
requested review from
FScholPer,
lurtz and
opajonk
as code owners
November 5, 2026 19:24
lurtz
approved these changes
Nov 6, 2026
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup scripts and feature tests need the catalog’s version and checksum metadata. Keeping its preparation in the shared reader makes that data available independently of the container installer and keeps metadata rules together after #198.
Move the metadata preparation to
catalog.load_setup_metadata()and have the installer use it for setup environments andshell-metadata. Move the existing metadata assertion to the catalog tests and document the boundary. Existing shell exports and installation behavior are preserved.Part of #190; follows #196 and #198.