Skip to content

fix: #752 added feature req option - #978

Merged
a-zw merged 1 commit into
mainfrom
fix_lifecycle_752
Oct 20, 2026
Merged

a-zw merged 1 commit into
mainfrom
fix_lifecycle_752

Conversation

@FScholPer

Copy link
Copy Markdown
Contributor

📌 Description

Adds feature req option in metrics.json generation

relates to #752

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines
  • assisted by copilot

Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-978: https://eclipse-score.github.io/docs-as-code/pr-978/

Comment thread docs/how-to/dashboards_and_quality_gates.rst
@NicolasFussberger

Copy link
Copy Markdown

I tried this branch in the lifecycle repo: eclipse-score/lifecycle#805

Resulting metrics.json file is here: https://eclipse-score.github.io/lifecycle/pr-805/metrics.json
Original metrics.json file here: https://eclipse-score.github.io/lifecycle/main/metrics.json

With the changes in this PR now containing:

    "feat_req": {
      "total": 27,
      "with_code_link": 0,
      "with_test_link": 10,
      "fully_linked": 0,
      "with_code_link_pct": 0.0,
      "with_test_link_pct": 37.03703703703704,
      "fully_linked_pct": 0.0
    }

27 is the correct number of lifecycle feature requirements. The other metrics also look plausible at least.
Out of these 27 multiple are actually in state invalid and I wonder if these should be filtered out here, but this is a separate issue :)

I cannot really comment on the implementation in this PR, but functionally it does solve the use case we have in lifecycle

@a-zw
a-zw merged commit 7cb45c3 into main Oct 20, 2026
35 checks passed
@a-zw
a-zw deleted the fix_lifecycle_752 branch October 20, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants