Mocking process launcher in pgm UT (#844)

* Mocking process launcher in pgm UT

* Fixing build

Author: MaciejKaszynski

score/launch_manager/src/daemon/src/process_group_manager/details/BUILD

@@ -446,6 +446,7 @@ lm_cc_test(
         "//score/launch_manager/src/daemon/src/alive_monitor:mock_supervision_factory",
         "//score/launch_manager/src/daemon/src/configuration:config",
         "//score/launch_manager/src/daemon/src/process_group_manager",
+        "//score/launch_manager/src/daemon/src/process_group_manager:mock_iprocess",
         "//score/launch_manager/src/daemon/src/recovery_client:mock_recovery_client",
         "//score/launch_manager/src/daemon/src/watchdog:mock_i_watchdog_if",
         "@googletest//:gtest_main",

score/launch_manager/src/daemon/src/process_group_manager/details/process_group_manager_UT.cpp

@@ -16,6 +16,7 @@
 #include "score/mw/launch_manager/alive_monitor/mock_alive_monitor.hpp"
 #include "score/mw/launch_manager/alive_monitor/mock_alive_supervision_handle.hpp"
 #include "score/mw/launch_manager/alive_monitor/mock_supervision_factory.hpp"
+#include "score/mw/launch_manager/process_group_manager/mock_iprocess.hpp"
 #include "score/mw/launch_manager/recovery_client/mock_recovery_client.h"
 #include "score/mw/launch_manager/watchdog/mock_IWatchdogIf.hpp"
 
@@ -115,6 +116,8 @@ GraphConfig takeGraphConfig(Config& config)
 class ProcessGroupManagerWatchdogTest : public Test
 {
   protected:
+    static constexpr osal::ProcessID kMockPid = 100;
+
     void expectNormalStartup()
     {
         EXPECT_CALL(*alive_monitor_, init()).WillOnce(Return(true));
@@ -149,14 +152,24 @@ class ProcessGroupManagerWatchdogTest : public Test
         auto watchdog = std::make_unique<StrictMock<MockWatchdogIf>>();
         watchdog_ = watchdog.get();
 
+        // Mock the proc launcher calls
+        auto process_interface = std::make_unique<NiceMock<osal::MockIProcess>>();
+        process_interface_ = process_interface.get();
+        ON_CALL(*process_interface_, startProcess)
+            .WillByDefault(DoAll(SetArgReferee<0>(kMockPid), Return(osal::OsalReturnType::kSuccess)));
+        ON_CALL(*process_interface_, waitForkRunning).WillByDefault(Return(osal::OsalReturnType::kSuccess));
+        ON_CALL(*process_interface_, requestTermination).WillByDefault(Return(osal::OsalReturnType::kSuccess));
+        ON_CALL(*process_interface_, forceTermination).WillByDefault(Return(osal::OsalReturnType::kFail));
+
         auto config = makeMinimalConfig();
 
         process_group_manager_ = std::make_unique<ProcessGroupManager>(
             takeGraphConfig(config),
             std::move(alive_monitor),
             std::move(recovery_client),
             std::move(watchdog),
-            config.takeWatchdog());
+            config.takeWatchdog(),
+            std::move(process_interface));
     }
 
     void TearDown() override
@@ -168,6 +181,7 @@ class ProcessGroupManagerWatchdogTest : public Test
     MockRecoveryClient* recovery_client_{};
     IRecoveryClient::RecoveryRequestCallback recovery_callback_{};
     MockWatchdogIf* watchdog_{};
+    osal::MockIProcess* process_interface_{};
     NiceMock<MockSupervisionFactory> factory_{};
     std::unique_ptr<ProcessGroupManager> process_group_manager_;
 };

score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp

@@ -44,10 +44,11 @@ ProcessGroupManager::ProcessGroupManager(
     std::unique_ptr<saf::daemon::IAliveMonitor> alive_monitor,
     std::shared_ptr<IRecoveryClient> recovery_client,
     std::unique_ptr<score::mw::lifecycle::internal::watchdog::IWatchdogIf> watchdog,
-    std::optional<configuration::WatchdogConfig>&& watchdog_config)
+    std::optional<configuration::WatchdogConfig>&& watchdog_config,
+    std::unique_ptr<osal::IProcess> process_interface)
     : configuration_(std::move(config)),
       watchdog_config_(watchdog_config),
-      process_interface_(),
+      process_interface_(std::move(process_interface)),
       file_waiter_(),
       process_map_(nullptr),
       thread_pool_(nullptr),
@@ -148,7 +149,8 @@ bool ProcessGroupManager::initializeProcessGroups()
         configuration_.components_.size() + configuration_.run_targets_.size() + 2,
         configuration_,
         worker_jobs_,
-        ProcessHandling{&process_interface_, process_map_, &file_waiter_, alive_monitor_->getSupervisionFactory()});
+        ProcessHandling{
+            process_interface_.get(), process_map_, &file_waiter_, alive_monitor_->getSupervisionFactory()});
 
     LM_LOG_DEBUG() << "Graph initialized successfully";
     return true;

score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.hpp

@@ -72,12 +72,15 @@ class ProcessGroupManager final : public IRunTargetControl
     /// the Alive Monitor thread of process state changes.
     /// @param watchdog A unique pointer to an IWatchdogIf instance serviced during the main loop. May be nullptr in
     /// legacy configuration where no watchdog is wired.
+    /// @param process_interface The interface used to launch and terminate processes. Defaults to the POSIX
+    /// ProcessLauncher.
     ProcessGroupManager(
         GraphConfig&& config,
         std::unique_ptr<saf::daemon::IAliveMonitor> alive_monitor,
         std::shared_ptr<IRecoveryClient> recovery_client,
         std::unique_ptr<score::mw::lifecycle::internal::watchdog::IWatchdogIf> watchdog,
-        std::optional<configuration::WatchdogConfig>&& watchdog_config);
+        std::optional<configuration::WatchdogConfig>&& watchdog_config,
+        std::unique_ptr<osal::IProcess> process_interface = std::make_unique<osal::ProcessLauncher>());
 
     /// @brief Initializes the process group manager.
     /// Sets up a signal handler for SIGINT and SIGTERM so that the main loop of
@@ -197,7 +200,7 @@ class ProcessGroupManager final : public IRunTargetControl
     std::optional<configuration::WatchdogConfig> watchdog_config_;
 
     /// @brief The process interface object associated with the ProcessGroupManager.
-    osal::ProcessLauncher process_interface_;
+    std::unique_ptr<osal::IProcess> process_interface_;
 
     /// @brief Waits for FileState ready conditions; injected into ProcessInfoNode via ProcessHandling.
     osal::FileWaiter file_waiter_;