Repository navigation
Replace pid in shared memory with actual bitpattern - #830
Draft
NicolasFussberger wants to merge 1 commit into
Draft
NicolasFussberger wants to merge 1 commit into
NicolasFussberger wants to merge 1 commit into
Conversation
NicolasFussberger
force-pushed
the
report_running_bitpattern
branch
4 times, most recently
from
October 23, 2026 13:21
9a3a401 to
9f4340f
Compare
NicolasFussberger
force-pushed
the
report_running_bitpattern
branch
from
October 26, 2026 06:48
9f4340f to
3c6ff46
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pid in shared memory actually served as an "expected bitpattern" so a client opening the shared memory from fd can be sure that its really the shared memory from LM (and not some file the process happed to have open with this fd, if it was not started by LM).
This was actually a poor saveguard and it here replaced with an explicit bitpattern.