Skip to content

Fix flaky tests - #840

Merged
NicolasFussberger merged 6 commits into
eclipse-score:mainfrom
etas-contrib:fix-flaky-tests
Oct 23, 2026
Merged

Fix flaky tests#840
NicolasFussberger merged 6 commits into
eclipse-score:mainfrom
etas-contrib:fix-flaky-tests

Conversation

@MaciejKaszynski

@MaciejKaszynski MaciejKaszynski commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

seems to be less flaky

Also fixes #512

  • Waiting for a test end now polls the atomic bool to see if it got the sigterm signal.
  • removed "Off" state transitions.
  • added wait for client method to make sure the mw::com stuff is working before starting the test.

@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 10:07 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 10:07 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 10:07 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 10:07 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-840: https://eclipse-score.github.io/lifecycle/pr-840/

danth
danth reviewed Oct 22, 2026
View reviewed changes
Comment thread tests/utils/test_helper/test_helper.hpp Outdated
Comment thread tests/utils/test_helper/test_helper.hpp
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 14:53 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 14:53 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 22, 2026 14:53 — with GitHub Actions Active
@MaciejKaszynski

MaciejKaszynski commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Think I've re ran this about 6 times now so seems pretty good. There was one failure that was actually a UT failure https://github.com/eclipse-score/lifecycle/actions/runs/39791639469/job/119868938306?pr=840#step:5:646 Should be fixed in #844

NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/details/lm_control_impl.hpp Outdated
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread tests/utils/test_helper/test_runner.hpp
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/details/lm_control_impl.hpp Outdated
NicolasFussberger
NicolasFussberger reviewed Oct 23, 2026
View reviewed changes
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
TimoSteuerwaldETAS
TimoSteuerwaldETAS approved these changes Oct 23, 2026
View reviewed changes

@TimoSteuerwaldETAS TimoSteuerwaldETAS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Thanks for your contribution! 🥰

@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 23, 2026 09:25 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 23, 2026 09:25 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 23, 2026 09:25 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval October 23, 2026 09:25 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026
@NicolasFussberger
NicolasFussberger added this pull request to the merge queue Oct 23, 2026
Merged via the queue into eclipse-score:main with commit 5493990 Oct 23, 2026
21 checks passed
@NicolasFussberger
NicolasFussberger deleted the fix-flaky-tests branch October 23, 2026 12:54
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 23, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — ddf62c98 Deployed Oct 23, 2026 by MaciejKaszynski via Build and test x86_64-qnx / approval #1717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasFussberger NicolasFussberger NicolasFussberger approved these changes
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+2 more reviewers
@danth danth danth left review comments
@TimoSteuerwaldETAS TimoSteuerwaldETAS TimoSteuerwaldETAS approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible API extension: Waiting for successful connection

4 participants

@MaciejKaszynski @danth @TimoSteuerwaldETAS @NicolasFussberger