Skip to content

Deprecate ready recovery action, introduce activation_retries instead - #848

Open
NicolasFussberger wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:deprecate_ready_recovery_action
Open

Deprecate ready recovery action, introduce activation_retries instead#848
NicolasFussberger wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:deprecate_ready_recovery_action

Conversation

@NicolasFussberger

@NicolasFussberger NicolasFussberger commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR marks ready_recovery_action as deprecated, instead, introduces two new attributes with identical functionality:

"activation_retry_attempts": [0, 255]

  • Specifies the number of additional attempts the Launch Manager makes to activate the component when it fails to reach its Ready State during a Run Target transition. A value of 0 means the component is started once and a failure is treated as a Run Target transition failure.

"activation_retry_delay_ms": [0, 4294967295]

  • Specifies the delay duration, in milliseconds, that the Launch Manager waits before each activation retry. (Not yet implemented)

This was decided in lifecycle call 2026-10-14 to better separate this from the "regular" Recovery Action.
Having too types of recovery actions in the configuration is too confusing to the user.

@github-actions

github-actions Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-848: https://eclipse-score.github.io/lifecycle/pr-848/

@NicolasFussberger
NicolasFussberger marked this pull request as ready for review October 26, 2026 07:10
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 26, 2026 07:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 26, 2026 07:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 26, 2026 07:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 26, 2026 07:10 — with GitHub Actions Active
danth
danth reviewed Oct 26, 2026
View reviewed changes

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small comment

Comment thread score/launch_manager/src/daemon/src/configuration/config_schema/launch_manager.schema.json Outdated
NicolasFussberger and others added 4 commits October 26, 2026 13:53
@NicolasFussberger
Deprecate Ready Recovery Action
27fa76f
@NicolasFussberger
Fix single activation_retries value
0b472db
@NicolasFussberger
Split into two values
932856e
@NicolasFussberger @danth
Update schema
eee0851 
Co-authored-by: Daniel Thwaites <danth@danth.me>
Signed-off-by: Nicolas Fußberger <145956508+NicolasFussberger@users.noreply.github.com>
@NicolasFussberger
NicolasFussberger force-pushed the deprecate_ready_recovery_action branch from bdce7df to eee0851 Compare October 26, 2026 12:53
MaciejKaszynski
MaciejKaszynski requested changes Oct 28, 2026
View reviewed changes

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. However, could you also already create a release note for the breaking changes with migration steps.

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — eee08514 Waiting Oct 26, 2026 by NicolasFussberger via Build and test arm64-qnx / approval #1784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski requested changes
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@danth danth danth left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasFussberger @danth @MaciejKaszynski