Repository navigation
LmControl API - Support callback registration before connection - #849
Open
NicolasFussberger wants to merge 1 commit into
Open
NicolasFussberger wants to merge 1 commit into
NicolasFussberger wants to merge 1 commit into
Conversation
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 23, 2026 13:29
NicolasFussberger
requested a deployment
to
workflow-approval
October 23, 2026 13:29 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 23, 2026 13:29 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 23, 2026 13:29 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 23, 2026 13:29 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
|
Documentation preview for this pull request is available at: |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where previously LmControl API would crash if the activation callback is registered before a connection had been established to the Launch Manager.
Problematic sequence:
User: register_run_target_activation_callback()
-> onActivationResult()
-> readActivationEvents() <-- Assumes that proxy is already created
Now
onActivationResult()is only called if the proxy object has already been created (i.e. connection already established).