Fixes rst_to_trlc parser

- Strip triling sphinx filter suffixes
- Consume multi-line directive arg lines before
field list parsing

Author: rmaddikery

bazel/rules/rules_score/private/rst_to_trlc.bzl

@@ -63,9 +63,7 @@ def _rst_to_trlc_impl(ctx):
     """Convert each .rst source file to a .trlc file via the Python converter."""
     outs = []
     for src in ctx.files.srcs:
-        # Declared in this rule's own package rather than next to `src` (via
-        # `sibling`), since `src` may come from a different repository (e.g.
-        # a cross-repo RST label), where declare_file(sibling=...) is invalid.
+        # `src` may come from a different repository (E.g.: a cross-repo RST label)
         out = ctx.actions.declare_file(src.basename[:-4] + ".trlc")
         outs.append(out)
 

bazel/rules/rules_score/src/rst_to_trlc.py

@@ -83,6 +83,7 @@
 _RE_MARKUP = re.compile(r"\*\*?(.*?)\*\*?")
 _RE_DIRECTIVE = re.compile(r"^\.\.\s+([\w]+)::\s*(.*)")
 _RE_FIELD = re.compile(r"^\s+:([\w]+):\s*(.*)")  # noqa: E501
+_RE_NEEDS_FILTER = re.compile(r"(\s*\[[^\[\]]*\])+\s*$")
 
 _TRLC_HEADER = """\
 /********************************************************************************
@@ -136,8 +137,19 @@ def _escape(text: str) -> str:
 
 
 def _collect_refs(fields: dict[str, str]) -> list[str]:
-    """Extract all cross-reference IDs from relationship fields."""
-    return [r.strip() for k in _REF_FIELDS if k in fields for r in fields[k].split(",") if r.strip()]
+    """Extract all cross-reference IDs from relationship fields.
+
+    Strips one or more trailing sphinx-needs filter expressions (E.g.:
+    [version==1] or [version==1][status==valid]), which are not
+    valid in TRLC reference syntax.
+    """
+    return [
+        _RE_NEEDS_FILTER.sub("", r.strip()).strip()
+        for k in _REF_FIELDS
+        if k in fields
+        for r in fields[k].split(",")
+        if r.strip()
+    ]
 
 
 def parse_directives(content: str) -> list[dict[str, Any]]:
@@ -154,6 +166,14 @@ def parse_directives(content: str) -> list[dict[str, Any]]:
         directive, title = m.group(1), m.group(2).strip()
         i += 1
 
+        # RST directive arguments may wrap onto continuation lines (docutils
+        # allows this); consume any such lines here before the field list,
+        # otherwise they get mis-parsed as body text and the real :id: (and
+        # other fields) on the following lines are missed entirely.
+        while i < len(lines) and lines[i].strip() and not _RE_FIELD.match(lines[i]):
+            title += " " + lines[i].strip()
+            i += 1
+
         fields, i = _collect_fields(lines, i)
         raw_body, i = _collect_body(lines, i)
         body = _RE_MARKUP.sub(r"\1", raw_body).strip()

bazel/rules/rules_score/test/rst_to_trlc_test.py

@@ -336,6 +336,37 @@ def test_strips_rst_bold_markup_from_body(self):
         self.assertNotIn("**", result[0]["body"])
         self.assertIn("robust", result[0]["body"])
 
+    def test_multi_line_title_is_joined_and_fields_still_parsed(self):
+        """docutils allows a directive's argument to wrap onto continuation
+        lines with no blank-line separator; the real field list must still
+        be found on the lines that follow."""
+        rst = _rst(
+            ".. comp_req:: Logging During the C++ Static Storage",
+            "   construction and destruction.",
+            "   :id: comp_req__test__001",
+            "   :safety: QM",
+            "",
+            "   Body.",
+        )
+        result = parse_directives(rst)
+        self.assertEqual(len(result), 1)
+        self.assertEqual(
+            result[0]["title"],
+            "Logging During the C++ Static Storage construction and destruction.",
+        )
+        self.assertEqual(result[0]["fields"]["id"], "comp_req__test__001")
+
+    def test_single_line_title_unaffected_by_continuation_handling(self):
+        rst = _rst(
+            ".. feat_req:: Single Line Title",
+            "   :id: feat_req__test__001",
+            "   :safety: QM",
+            "",
+            "   Body.",
+        )
+        result = parse_directives(rst)
+        self.assertEqual(result[0]["title"], "Single Line Title")
+
 
 # ---------------------------------------------------------------------------
 # render_trlc – TRLC output for each S-CORE type
@@ -545,6 +576,25 @@ def test_mitigates_is_not_a_ref_field(self):
     def test_returns_empty_when_no_ref_fields(self):
         self.assertEqual(_collect_refs({"safety": "QM", "reqtype": "Functional"}), [])
 
+    def test_strips_trailing_needs_filter(self):
+        """sphinx-needs filter suffixes are not valid TRLC reference syntax."""
+        self.assertEqual(
+            _collect_refs({"satisfies": "req_001[version==1]"}),
+            ["req_001"],
+        )
+
+    def test_strips_multiple_trailing_needs_filters(self):
+        self.assertEqual(
+            _collect_refs({"satisfies": "req_001[version==1][status==valid]"}),
+            ["req_001"],
+        )
+
+    def test_strips_needs_filter_from_each_comma_separated_ref(self):
+        self.assertEqual(
+            _collect_refs({"satisfies": "req_001[version==1], req_002[status==valid]"}),
+            ["req_001", "req_002"],
+        )
+
 
 # ---------------------------------------------------------------------------
 # _collect_body – blank-line handling consistency