Repository navigation
[5.2] Fix PgEncoder to fully close the connection on idle timeout - #1761
Merged
Merged
Conversation
See #1755 The `PgEncoder` close override sends the Terminate message but was not propagating the close, so the channel never fully closed when `readIdleTimeout` fired on an unresponsive connection. Propagate `ctx.close(promise)` when `closeSent` is false; otherwise wire the promise to `ch.closeFuture()` to let the normal `shutdownOutput` cycle complete without cutting off in-flight server responses. Add `testReadIdleTimeoutClosesConnection` using a Vert.x `NetServer` with `ALLOW_HALF_CLOSURE` to simulate an unresponsive server that doesn't send FIN back. Fix `testMaximumParametersExceeded` to use `asyncAssertFailure` so the VertxUnit runner waits for the query result. Without this, the runner tears down the `Vertx` instance immediately after the test method returns, closing the PG connection before the server response arrives, which changes the failure reason from a parameter count error to a connection lost error. Assisted-By: Claude Opus 4.6 Signed-off-by: Thomas Segismont <tsegismont@gmail.com> (cherry picked from commit faf9310) Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1760 to
5.2Cherry-picked commit: faf9310