Skip to content

Complete close() of a lazy PG prepared statement that was never executed #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharanggupta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete close() of a lazy PG prepared statement that was never executed #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,17 @@ public void testInferDataTypeLazy42P18(TestContext ctx) {
}));
}

@Test
public void testCloseLazyPreparedStatementNotExecuted42P18(TestContext ctx) {
PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> {
conn
.prepare("SELECT CONCAT('HELLO', $1)")
.compose(PreparedStatement::close)
.eventually(() -> conn.close())
.onComplete(ctx.asyncAssertSuccess());
}));
}

@Test
public void testInferDataTypeFailure42P18(TestContext ctx) {
PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> {
Expand Down
4 changes: 4 additions & 0 deletions vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PreparedStatementBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ protected void close(Promise<Void> promise) {
promise.fail(ar.cause());
}
});
} else {
// Never executed, so never prepared: nothing to close, and it must not be prepared afterwards
future = context.failedFuture("Prepared statement closed");
promise.complete();
}
}
@Override
Expand Down