Skip to content

[MySQL] Decode zero DATETIME(n) text values as null #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsegismont merged 2 commits into from
Nov 13, 2026
+18 −3
Merged

[MySQL] Decode zero DATETIME(n) text values as null #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
783ac26
Decode zero DATETIME(n) text values as null
sharanggupta Oct 28, 2026
9fd2a02
Compare zero dates as strings
sharanggupta Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/datatype/DataTypeCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ private static String textDecodeText(int collationId, ByteBuf buffer, int index,

private static LocalDate textDecodeDate(int collationId, ByteBuf buffer, int index, int length) {
Charset charset = MySQLCollation.getJavaCharsetByCollationId(collationId);
CharSequence cs = buffer.toString(index, length, charset);
String cs = buffer.toString(index, length, charset);
if (cs.equals("0000-00-00")) {
// Invalid date will be converted to zero
return null;
Expand Down Expand Up @@ -743,8 +743,8 @@ private static Duration textDecodeTime(int collationId, ByteBuf buffer, int inde

private static LocalDateTime textDecodeDateTime(int collationId, ByteBuf buffer, int index, int length) {
Charset charset = MySQLCollation.getJavaCharsetByCollationId(collationId);
CharSequence cs = buffer.toString(index, length, charset);
if (cs.equals("0000-00-00 00:00:00")) {
String cs = buffer.toString(index, length, charset);
if (cs.startsWith("0000-00-00 00:00:00")) {
// Invalid datetime will be converted to zero
return null;
}
Expand Down
15 changes: 15 additions & 0 deletions vertx-mysql-client/src/test/java/io/vertx/tests/mysqlclient/data/DateTimeTextCodecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ public void testDecodeTimestamp(TestContext ctx) {
testTextDecodeGenericWithTable(ctx, "test_timestamp", LocalDateTime.of(2000, 1, 1, 10, 20, 30));
}

@Test
public void testDecodeDatetimeWithFractionalSecondsEmpty(TestContext ctx) {
MySQLConnection.connect(vertx, options).onComplete(ctx.asyncAssertSuccess(conn -> {
conn
.query("SET SESSION sql_mode = ''")
.execute()
.compose(v -> conn.query("SELECT CAST('0000-00-00 00:00:00' AS DATETIME(6)) test_datetime").execute())
.onComplete(ctx.asyncAssertSuccess(result -> {
ctx.assertEquals(1, result.size());
ctx.assertNull(result.iterator().next().getValue("test_datetime"));
conn.close();
}));
}));
}

@Override
protected <T> void testDecodeGeneric(TestContext ctx, String data, String dataType, String columnName, T expected) {
testDecodeGeneric(ctx, data, dataType, row -> {
Expand Down
Loading