Repository navigation
Fix encoding of negative fractional TIME values - #1772
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
Duration.getSeconds() is floored, so borrowing a second for the fraction wrote second = -1 whenever the floored value was a whole minute, and MySQL stored -59.5 seconds as zero. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev> Assisted-by: Anthropic Claude (claude-opus-5-5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative
Durationwith a fraction is encoded by borrowing one second from the flooredgetSeconds(), so whenever that lands on a whole minute the second field becomes -1 and MySQL stores the wrong value:Duration.ofSeconds(-59).minusMillis(500)is read back as zero. The fields are now taken from the absolute duration with the sign sent separately. The test round-trips that value through aTIME(6)column.