Repository navigation
Parse text TIME fractions without a double - #1773
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
Going through Double.parseDouble truncated some fractions by a nanosecond, so '00:00:00.000065' decoded to 64999 ns. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev> Assisted-by: Anthropic Claude (claude-opus-5-5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text protocol parses the fractional seconds of a
TIMEvalue throughDouble.parseDoubleand truncates the product, so some values come back one nanosecond short:11:12:00.000065decodes toPT11H12M0.000064999S. The digits are now parsed as an integer and scaled to nanoseconds. The new test runs for both protocols; only the text one failed before.