Skip to content

Parse text TIME fractions without a double #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharanggupta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parse text TIME fractions without a double #1773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/datatype/DataTypeCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,8 +731,7 @@ private static Duration textDecodeTime(int collationId, ByteBuf buffer, int inde
int second = Integer.parseInt(timeElements[2].substring(0, 2));
long nanos = 0;
if (timeElements[2].length() > 2) {
double fractionalSecondsPart = Double.parseDouble("0." + timeElements[2].substring(3));
nanos = (long) (1000000000 * fractionalSecondsPart);
nanos = Long.parseLong((timeElements[2].substring(3) + "00000000").substring(0, 9));
}
if (isNegative) {
return Duration.ofHours(-hour).minusMinutes(minute).minusSeconds(second).minusNanos(nanos);
Expand Down
5 changes: 5 additions & 0 deletions vertx-mysql-client/src/test/java/io/vertx/tests/mysqlclient/data/DateTimeCodecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ public void testDecodeFractionalSecondsPart(TestContext ctx) {
testDecodeGeneric(ctx, "11:12:00.123456", "TIME(6)", "test_time", Duration.ofHours(11).plusMinutes(12).plusNanos(123456000));
}

@Test
public void testDecodeSmallFractionalSecondsPart(TestContext ctx) {
testDecodeGeneric(ctx, "11:12:00.000065", "TIME(6)", "test_time", Duration.ofHours(11).plusMinutes(12).plusNanos(65000));
}

@Test
public void testDecodeTimeAsLocalTimeWithFractionalSecondsPart(TestContext ctx) {
testDecodeGeneric(ctx, "11:12:00.123456", "TIME(6)", row -> {
Expand Down