Repository navigation
Encode JSON parameters in the connection charset - #1774
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
Since eclipse-vertx#1685 JSON parameters were always written as UTF-8, so a connection with a non-UTF-8 collation received garbled text. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev> Assisted-by: Anthropic Claude (claude-opus-5-5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1685, MySQL
JsonObject/JsonArrayparameters are always written as UTF-8, while the rest of the parameters use the connection's encoding charset. On a connection with a non-UTF-8 collation, such asgbk_chinese_ci, the server reads garbled text:{"city":"北京"}comes back as鍖椾含. UTF-8 connections keep the direct encoding; others go through the charset again, as before #1685. The new test passes on the commit before #1685.