From 4fc0f05a8fade58188593e4210d23c3a7821a4be Mon Sep 17 00:00:00 2001 From: Sharang Gupta Date: Thu, 29 Oct 2026 00:10:32 +0000 Subject: [PATCH] Decode SMALLMONEY with four decimal places SMALLMONEY is stored in ten-thousandths, but the decoder rounded it up to two decimals, so 214748.3647 was returned as 214748.37. MONEY already uses four. Signed-off-by: Sharang Gupta Assisted-by: Anthropic Claude (claude-opus-5-5) --- .../mssqlclient/impl/codec/DataType.java | 2 +- .../data/MSSQLFullDataTypeTestBase.java | 4 ++-- ...LPreparedQueryNotNullableDataTypeTest.java | 2 +- ...SSQLPreparedQueryNullableDataTypeTest.java | 2 +- .../data/MSSQLSmallMoneyDataTypeTest.java | 22 ++++++++++++++----- 5 files changed, 21 insertions(+), 11 deletions(-) diff --git a/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/DataType.java b/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/DataType.java index 19fd76fb4b..349a9ee2fd 100644 --- a/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/DataType.java +++ b/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/DataType.java @@ -219,7 +219,7 @@ public TypeInfo decodeTypeInfo(ByteBuf byteBuf) { @Override public Object decodeValue(ByteBuf byteBuf, TypeInfo typeInfo) { - return new BigDecimal(byteBuf.readIntLE()).divide(new BigDecimal("10000"), 2, RoundingMode.UP); + return new BigDecimal(byteBuf.readIntLE()).divide(new BigDecimal("10000"), 4, RoundingMode.UP); } @Override diff --git a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLFullDataTypeTestBase.java b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLFullDataTypeTestBase.java index b9d066abb0..831f806158 100644 --- a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLFullDataTypeTestBase.java +++ b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLFullDataTypeTestBase.java @@ -53,7 +53,7 @@ public void testDecodeAllColumns(TestContext ctx) { ctx.assertEquals(Buffer.buffer("venice of the north"), row.getValue("test_varbinary_max")); ctx.assertEquals(Buffer.buffer("paris of the west"), row.getValue("test_image")); ctx.assertEquals(new BigDecimal("12.3456"), row.getValue("test_money")); - ctx.assertEquals(new BigDecimal("12.34"), row.getValue("test_smallmoney")); + ctx.assertEquals(new BigDecimal("12.3400"), row.getValue("test_smallmoney")); }); } @@ -266,7 +266,7 @@ public void testDecodeMoney(TestContext ctx) { @Test public void testDecodeSmallMoney(TestContext ctx) { testDecodeNotNullValue(ctx, "test_smallmoney", row -> { - checkNumber(row, "test_smallmoney", new BigDecimal("12.34")); + checkNumber(row, "test_smallmoney", new BigDecimal("12.3400")); }); } diff --git a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java index 0a4c28adc3..0e13195307 100644 --- a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java +++ b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java @@ -319,7 +319,7 @@ public void testEncodeMoney(TestContext ctx) { @Test public void testEncodeSmallMoney(TestContext ctx) { testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_smallmoney", "€12.12", row -> { - checkNumber(row, "test_smallmoney", new BigDecimal("12.12")); + checkNumber(row, "test_smallmoney", new BigDecimal("12.1200")); }); } diff --git a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNullableDataTypeTest.java b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNullableDataTypeTest.java index d5da959729..17bb120161 100644 --- a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNullableDataTypeTest.java +++ b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNullableDataTypeTest.java @@ -460,7 +460,7 @@ public void testEncodeNullMoney(TestContext ctx) { @Test public void testEncodeNullSmallMoney(TestContext ctx) { - testEncodeNumber(ctx, "test_smallmoney", new BigDecimal("123.13")); + testEncodeNumber(ctx, "test_smallmoney", new BigDecimal("123.1313")); } private void testEncodeBufferValue(TestContext ctx, String columnName, Object value, Object expected) { diff --git a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLSmallMoneyDataTypeTest.java b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLSmallMoneyDataTypeTest.java index 918a161659..54f9897311 100644 --- a/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLSmallMoneyDataTypeTest.java +++ b/vertx-mssql-client/src/test/java/io/vertx/tests/mssqlclient/data/MSSQLSmallMoneyDataTypeTest.java @@ -23,31 +23,41 @@ public class MSSQLSmallMoneyDataTypeTest extends MSSQLDataTypeTestBase { @Test public void testQueryLargeMoney(TestContext ctx) { - testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.36", new BigDecimal("214748.36")); + testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.36", new BigDecimal("214748.3600")); + } + + @Test + public void testQueryMaxMoney(TestContext ctx) { + testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.3647", new BigDecimal("214748.3647")); } @Test public void testQueryLargeNegativeMoney(TestContext ctx) { - testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "-214748.36", new BigDecimal("-214748.36")); + testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "-214748.36", new BigDecimal("-214748.3600")); } @Test public void testQueryMoneyWithCurrency(TestContext ctx) { - testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "$12.34", new BigDecimal("12.34")); + testQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "$12.34", new BigDecimal("12.3400")); } @Test public void testPreparedQueryLargeMoney(TestContext ctx) { - testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.36", new BigDecimal("214748.36")); + testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.36", new BigDecimal("214748.3600")); + } + + @Test + public void testPreparedQueryMaxMoney(TestContext ctx) { + testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "214748.3647", new BigDecimal("214748.3647")); } @Test public void testPreparedQueryLargeNegativeMoney(TestContext ctx) { - testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "-214748.36", new BigDecimal("-214748.36")); + testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "-214748.36", new BigDecimal("-214748.3600")); } @Test public void testPreparedQueryMoneyWithCurrency(TestContext ctx) { - testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "$12.34", new BigDecimal("12.34")); + testPreparedQueryDecodeGenericWithoutTable(ctx, "test_smallmoney", "SMALLMONEY", "$12.34", new BigDecimal("12.3400")); } }