Skip to content

Encode negative-scale BigDecimal values correctly #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharanggupta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Encode negative-scale BigDecimal values correctly #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/DataType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,14 @@ public String paramDefinition(Object value) {
@Override
public void encodeParam(ByteBuf byteBuf, String name, boolean out, Object value) {
BigDecimal bigDecimal = (BigDecimal) value;
if (bigDecimal.scale() < 0) {
bigDecimal = bigDecimal.setScale(0);
}
writeParamDescription(byteBuf, name, out, id);
writeParamSize(byteBuf, 17, 38);
int sign = bigDecimal.signum() < 0 ? 0 : 1;
byte[] bytes = (sign == 0 ? bigDecimal.negate() : bigDecimal).unscaledValue().toByteArray();
byteBuf.writeByte(Math.max(0, bigDecimal.scale()));
byteBuf.writeByte(bigDecimal.scale());
byteBuf.writeByte(1 + bytes.length);
byteBuf.writeByte(sign);
for (int i = bytes.length - 1; i >= 0; i--) byteBuf.writeByte(bytes[i]);
Expand Down
7 changes: 7 additions & 0 deletions .../test/java/io/vertx/tests/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ public void testEncodeDecimal(TestContext ctx) {
testEncodeNumber(ctx, "test_decimal", new BigDecimal("123456789"));
}

@Test
public void testEncodeDecimalWithNegativeScale(TestContext ctx) {
testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_decimal", new BigDecimal("1500").stripTrailingZeros(), row -> {
checkNumber(row, "test_decimal", new BigDecimal("1500"));
});
}

@Test
public void testEncodeBit(TestContext ctx) {
testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_boolean", false, row -> {
Expand Down