Avoid pending approval scans during chat redisplay - #307
Open
plux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ECA searched the full chat buffer to find pending tool approvals. Emacs ran this
search when it updated the mode line and tab line.
The search became slower as the chat buffer grew. Long chat sessions could
therefore make Emacs slow.
Changes
Investigation
A CPU profile showed that the pending approval search used 61.13% of CPU
samples. The ECA mode-line, tab-line, and header-line code used 63.13% of CPU
samples.
I then turned off the ECA chat tab line and custom mode line. The pending
approval search dropped to 3.08% of CPU samples. The related ECA status code
dropped to 0.36%.
These results showed that repeated full-buffer searches caused the slowdown.