Skip to content

Implement manual tool call approval #25

Closed

Description

@tomgeorge

I think this is a prerequisite for #9 (maybe). If you have an eca config that looks like this:

{
 ...
  "toolCall": {
    "manualApproval": [
      "eca_edit_file"
    ]
 
}

The screen hangs with

⏳ Waiting for tool call approval

Doing a grep through the code there doesn't look like a way to approve tools.

Activity

  1. self-assigned this
    on Aug 16, 2025
  2. ericdallo commented on Aug 16, 2025

    @ericdallo
    Member

    BTW it's not a blocker for #9 as we should show the diff for any tool that editting/created files, with or without manual approval.

  3. removed their assignment
    on Aug 18, 2025
  4. DaJiangCK commented on Sep 4, 2025

    @DaJiangCK

    I'm experiencing the same issue in Neovim — it's stuck at ⏳ Waiting for tool call approval, and I can't find a way to approve it.

  5. ericdallo commented on Sep 4, 2025

    @ericdallo
    Member

    I believe @tomgeorge have a working branch for that?

  6. ericdallo commented on Sep 4, 2025

    @ericdallo
    Member

    @DaJiangCK meanwhile, you can set a toolCall approval byDefault to allow, obviously as a workaround

  7. joaopluigi commented on Jan 7, 2026

    @joaopluigi
    Contributor

    We already have a very basic tool call approval implemented in #43. We have #9 to make that better integrated to the chat window, but the feature itself is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions