[UNTESTED] Platform/a52q: fix stale ACPI table filename reference - #447
Open
ayberkcn8181 wants to merge 1 commit into
Open
ayberkcn8181 wants to merge 1 commit into
ayberkcn8181 wants to merge 1 commit into
Conversation
Silicon/Qualcomm/sm7125's AcpiTables/BuiltIn/MADT.aml was renamed to APIC.aml in commit a23d912 ("Miatoll: Update AcpiTables"), but a52q.fdf.inc was never updated to match (a52q hasn't been touched since its initial bring-up in PR edk2-porting#275). This left the a52q build broken with "File/directory not found in workspace" for anyone attempting to build it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ayberkcn8181
changed the title
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Not yet tested on real hardware. This fix has only been verified by a clean local build (see Test plan below). I have not yet flashed or booted this on a physical Galaxy A52 (a52q) device. Please treat this as unverified on-device until updated.
Summary
Silicon/Qualcomm/sm7125/AcpiTables/BuiltIn/MADT.amlwas renamed toAPIC.amlin a23d912 ("Miatoll: Update AcpiTables"), butPlatform/Samsung/sm7125/a52q.fdf.incwas never updated to match.Test plan
./build.sh --device a52q --installer-zipafter the fix — build now completes successfully and producesboot-a52q.img/uefi-installer-a52q.zip.🤖 Generated with Claude Code