Repository navigation
Weather animation polish: overcast sky, ground effects, matched dividers - #978
Merged
Merged
Conversation
- Clouds/fog: paint a dim sky and draw lighter clouds (was grey-on-white smoke). Split partly-cloudy (symbol 2) into its own kind with a bluer, sunnier sky and sparser clouds so blue peeks through. - Box gains a full-bleed background slot: header/footer go transparent so the animation runs unbroken through the footer. Other boxes unchanged. - Dividers (header/footer + the morning/day/evening/night segments) take a hue matched to the sky (shared weatherSymbolToKind + weatherBorderColor in weather/asciiSky.ts). - Ground contact at the bottom edge: rain splashes, a melting snow layer that gathers per-column, and soft thud puffs as flakes land.
eetu
force-pushed
the
feat/weather-anim-polish
branch
from
June 16, 2026 16:43
4d7eaf4 to
c3e7eba
Compare
eetu
enabled auto-merge
June 16, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish on the weather ASCII animation (#977).
Changes
Overcast sky rework
Full-bleed animation through the footer
Boxgains an optionalbackgroundslot rendered behind header + footer; those surfaces go transparent so the animation runs unbroken across the footer seam. Every other box omits the prop and is unchanged.Hue-matched dividers
weatherSymbolToKind+ newweatherBorderColorintoweather/asciiSky.ts(single source of truth; the animation component imports the kind mapping instead of duplicating it).Ground contact at the bottom edge
Test plan
yarn validatepasses (typecheck, lint, format)?demo→ cyclepuolipilv./pilvinen/sumuto compare skies and dividers;rankka/lumito see splashes and the gathering snow layer