feat: cross-platform Chrome profile resolution with tests

  - Resolve Chrome profile lazily inside getCookiesFromBrowser; fall
    back to chrome-cookies-secure's own default when no match is found
  - Add getChromeUserDataDir() with macOS, Linux, and Windows paths so
    auto-detect and email/display-name lookup work on all three OSes
  - Drop --env-file=.env from npm start so the script works without
    a .env file; document .env as an optional way to set CHROME_PROFILE
  - Add unit tests for resolveProfile with on-disk profile fixtures
  - Migrate test imports from ts-jest/utils to jest-mock (deprecated
    in ts-jest v27, removed in v28)
  - Strip deprecated husky.sh sourcing from pre-commit and pre-push
    hooks (warned by husky v8+, fails in v10)
  - Restore cli.ts to tsconfig include so lib/cli.js is built
  - Pin engines.node to >=16

Author: a-magdy

.env.example

@@ -1,8 +1,8 @@
-# Chrome profile to read cookies from.
+# Chrome profile to read cookies from. Works on macOS, Linux, and Windows.
 # Accepted values:
 #   - Email address:    <firstname>.<lastname>@eficode.com
 #   - Profile name:     Eficode
-#   - Directory name:   Profile 2
+#   - Directory name:   Default, Profile 2
 #
 # If not set, defaults to the first profile with an @eficode.com email.
 # If no @eficode.com profile is found, falls back to "Default".

.husky/pre-commit

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx lint-staged

.husky/pre-push

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npm run typecheck && npm run test

README.md

@@ -8,12 +8,18 @@ Sign in to [Timesheets](https://timesheets.eficode.fi/) on Chrome.
 
 ## Chrome profiles
 
-If you use multiple Chrome profiles, the CLI tries to auto-detect your work profile by looking for one signed in with an `@eficode.com` email. Auto-detect works on macOS, Linux, and Windows. To override, set `CHROME_PROFILE` in a `.env` file (see `.env.example`):
+If you use multiple Chrome profiles, the CLI tries to auto-detect your work profile by looking for one signed in with an `@eficode.com` email. Auto-detect works on macOS, Linux, and Windows.
+
+To override, set the `CHROME_PROFILE` environment variable:
 
     CHROME_PROFILE=your.name@eficode.com   # or "Eficode", or "Profile 2"
 
 It accepts the account email, the profile display name, or the directory name (e.g. `Default`, `Profile 2`).
 
+Optionally, you can put it in a `.env` file (see `.env.example`) and load it with Node ≥20.6:
+
+    node --env-file=.env lib/cli.js
+
 ## Running
 
 `npx @eficode/tscli`

package.json

@@ -15,14 +15,17 @@
   "bin": {
     "tscli": "lib/cli.js"
   },
+  "engines": {
+    "node": ">=16"
+  },
   "files": [
     "lib/**/*"
   ],
   "scripts": {
     "prepare": "husky install && npm run build",
     "prepublishOnly": "npm test && npm run lint",
     "preversion": "npm run lint",
-    "start": "tsc && node --env-file=.env lib/cli.js",
+    "start": "tsc && node lib/cli.js",
     "build": "tsc",
     "release": "./node_modules/.bin/standard-version && git push --follow-tags",
     "test": "jest",
@@ -66,6 +69,8 @@
   },
   "lint-staged": {
     "*.{js,ts,json,md,html,yml,yaml}": "prettier --write",
-    "*.ts": "tslint -p tsconfig.json"
+    "*.ts": [
+      "bash -c 'tslint -p tsconfig.json'"
+    ]
   }
 }

src/cookies.ts

@@ -25,8 +25,10 @@ const getChromeUserDataDir = (): string | undefined => {
   }
 };
 
-const resolveProfile = (profileOrHint?: string): string | undefined => {
-  const chromeDir = getChromeUserDataDir();
+export const resolveProfile = (
+  profileOrHint?: string,
+  chromeDir: string | undefined = getChromeUserDataDir(),
+): string | undefined => {
   if (!chromeDir || !existsSync(chromeDir)) return profileOrHint;
 
   let eficodeProfile: string | undefined;

test/auth.test.ts

@@ -1,4 +1,4 @@
-import { mocked } from 'ts-jest/utils';
+import { mocked } from 'jest-mock';
 
 import { existsSync, promises } from 'fs';
 

test/cookies.test.ts

@@ -0,0 +1,34 @@
+import * as path from 'path';
+import { resolveProfile } from '../src/cookies';
+
+const fixtureDir = path.join(__dirname, 'data/chrome-profiles');
+
+describe('resolveProfile', () => {
+  it('matches by account email', () => {
+    expect(resolveProfile('first.last@eficode.com', fixtureDir)).toBe('Profile 1');
+  });
+
+  it('matches by profile display name', () => {
+    expect(resolveProfile('Eficode', fixtureDir)).toBe('Profile 1');
+  });
+
+  it('matches by directory name', () => {
+    expect(resolveProfile('Profile 2', fixtureDir)).toBe('Profile 2');
+  });
+
+  it('auto-detects an @eficode.com profile when no hint is given', () => {
+    expect(resolveProfile(undefined, fixtureDir)).toBe('Profile 1');
+  });
+
+  it('returns the hint when no profile matches', () => {
+    expect(resolveProfile('Profile 9', fixtureDir)).toBe('Profile 9');
+  });
+
+  it('returns the hint when the chrome dir does not exist', () => {
+    expect(resolveProfile('Default', '/nonexistent/path')).toBe('Default');
+  });
+
+  it('returns undefined when no hint, no chrome dir, and no eficode profile', () => {
+    expect(resolveProfile(undefined, '/nonexistent/path')).toBeUndefined();
+  });
+});

test/data/chrome-profiles/Default/Preferences

@@ -0,0 +1,4 @@
+{
+  "profile": { "name": "Personal" },
+  "account_info": [{ "email": "personal@gmail.com" }]
+}

test/data/chrome-profiles/Profile 1/Preferences

@@ -0,0 +1,4 @@
+{
+  "profile": { "name": "Eficode" },
+  "account_info": [{ "email": "first.last@eficode.com" }]
+}