Skip to content

Commit 301a86d

Browse files
ehsun-shclaude
andcommitted
Fix CI: unpin mypy target version, bump actions
mypy was pinned to python_version 3.11 while the matrix runs it on 3.12 and 3.13. Targeting 3.11 makes mypy reject numpy's stubs, which use `type` statements introduced in 3.12, so both newer jobs failed before checking any of our own code. Dropping the pin lets each matrix job type-check against its own interpreter, which is better coverage than the pin gave. Also bumps checkout/setup-python off the deprecated Node 20 runtime. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 376ac2a commit 301a86d

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ jobs:
1919
python-version: ["3.11", "3.12", "3.13"]
2020

2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@v5
2323

24-
- uses: actions/setup-python@v5
24+
- uses: actions/setup-python@v6
2525
with:
2626
python-version: ${{ matrix.python-version }}
2727
cache: pip

pyproject.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ select = ["E", "F", "W", "I", "N", "UP", "B", "SIM", "RUF"]
5959
"tests/**" = ["N802", "N803", "N806"]
6060

6161
[tool.mypy]
62-
python_version = "3.11"
62+
# No python_version pin: mypy targets whichever interpreter runs it, so the CI
63+
# matrix type-checks against each supported version. Pinning it to the minimum
64+
# while running on a newer interpreter makes mypy reject dependency stubs that
65+
# use syntax from the newer version.
6366
files = ["src", "tests"]
6467
disallow_untyped_defs = true
6568
disallow_incomplete_defs = true

0 commit comments

Comments
 (0)