Skip to content

Commit c52d798

Browse files
authored
Fixed flaky FallbackSyntheticSourceBlockLoaderTests (#158204)
1 parent c199a14 commit c52d798

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

muted-tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,6 @@ tests:
152152
- class: org.elasticsearch.xpack.esql.action.LookupJoinTypesIT
153153
method: testLookupJoinOthers {p0=EQ}
154154
issue: https://github.com/elastic/elasticsearch/issues/157452
155-
- class: org.elasticsearch.index.mapper.FallbackSyntheticSourceBlockLoaderTests
156-
method: testCanReuseAcrossBinaryBlocks
157-
issue: https://github.com/elastic/elasticsearch/issues/157945
158-
- class: org.elasticsearch.index.mapper.FallbackSyntheticSourceBlockLoaderTests
159-
method: testCanReuseTracksLastReadDoc
160-
issue: https://github.com/elastic/elasticsearch/issues/157946
161155
- class: org.elasticsearch.xpack.ml.integration.PyTorchModelIT
162156
method: testFailedDeploymentStats
163157
issue: https://github.com/elastic/elasticsearch/issues/157341

server/src/test/java/org/elasticsearch/index/mapper/FallbackSyntheticSourceBlockLoaderTests.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,12 @@ private void withIndex(int numDocs, CheckedBiConsumer<MapperService, LeafReaderC
114114

115115
private void withIndex(int numDocs, int valueLength, CheckedBiConsumer<MapperService, LeafReaderContext, IOException> test)
116116
throws IOException {
117+
// The DOC_VALUES_IGNORED_SOURCE format these tests exercise is only selected when this feature flag is enabled, which is the
118+
// default in snapshot builds but off in release builds.
119+
assumeTrue(
120+
"requires ignored_source_as_doc_values feature flag enabled",
121+
IgnoredSourceFieldMapper.IGNORED_SOURCE_AS_DOC_VALUES_FF.isEnabled()
122+
);
117123
var settings = Settings.builder()
118124
.put("index.mapping.source.mode", "synthetic")
119125
// DOC_VALUES_IGNORED_SOURCE requires the TSDB doc values format to be enabled

0 commit comments

Comments
 (0)