Disable this test on Windows - #158316
Merged
Merged
Conversation
smalyshev
added
>test
smalyshev
marked this pull request as ready for review
September 1, 2026 18:26
elasticsearchmachine
added
v9.6.0
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
prwhelan
approved these changes
Sep 1, 2026
smalyshev
enabled auto-merge (squash)
September 1, 2026 19:19
julian-elastic
approved these changes
Sep 1, 2026
julian-elastic
left a comment
julian-elastic
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good! One small nit below.
| } | ||
| } | ||
|
|
||
| @Before |
Contributor
There was a problem hiding this comment.
nit: This @Before runs for every method in the class, so it also skips testNoCollectionWithoutExternalData and testWarmAggregate, which do not have the granularity issue.
Contributor
Author
There was a problem hiding this comment.
Hm yes you are right, I'll make it more granular I guess, no reason to disable those.
smalyshev
disabled auto-merge
September 1, 2026 19:35
Member
|
Btw, you can add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows has really bad thread timer, we can't do much about it here.
Closes #158226