Conversation
|
|
||
| bool Redis::ping() | ||
| { | ||
| TRCMD_EXPECTOK("PING", "OK"); |
There was a problem hiding this comment.
Additional arguments to TRCMD_EXPECTOK are passed through as arguments to the Redis command ("PING"), so in this case it would send "PING OK". If you want to send a bare "PING" without any argument, you'd just want TRCMD_EXPECTOK("PING"); Is sending with the "OK" argument what you were intending? It's hard to tell without seeing a test for this command...
... which leads me to my next request: please implement a test for this in the integration tests. The pattern is pretty simple and straightforward but please ask if you have trouble.
There was a problem hiding this comment.
I've read documentation for PING command. Argument in PING command is returned for the successful response.
Ok. I'll implement test... Reply a comment when it will be done.
There was a problem hiding this comment.
I've read documentation for PING command. Argument in PING command is returned for the successful response.
Yeah and that's why I was asking, it's completely fine if you wanted to send "OK" and then expect that response in the test, but like I said I wasn't sure without seeing some usage of it. 😊
Thank you! 🙇
|
@ip75 Thank you so much for taking the time & effort to get this fixed up! It's nearly there, I just have a couple more requests to make sure this PR is up to our project's standards. Appreciate your effort, let's get this one across the line! 🏁 |
2 participants
Returns the server's liveliness response.