Skip to content

Show how many people are in a room under its name - #7568

Open
hayaksi1 wants to merge 3 commits into
element-hq:developfrom
hayaksi1:fix/3568-room-member-count
Open

Show how many people are in a room under its name#7568
hayaksi1 wants to merge 3 commits into
element-hq:developfrom
hayaksi1:fix/3568-room-member-count

Conversation

@hayaksi1

Copy link
Copy Markdown
Contributor

Content

Nothing on the timeline screen says how large a room is, so it is easy to forget whether a message is going to a handful of people or to a few thousand. Opening the room details and coming back is the only way to check.

The room's member count now sits under its name in the top bar, in the same tappable area that already opens the room details, so the layout gains a line rather than a control. Direct messages and spaces show nothing: the count is either obvious or meaningless there.

Motivation and context

Relates to #3568.

Tests

  • MessagesPresenterTest — a group room reports its joined member count, a direct message reports none.

These do not cover the count for a room whose members have not synced yet; the top bar then shows whatever count the room info carries, and updates when it changes.

Tested devices

  • Physical
  • Emulator
  • OS version(s): API 36

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

hayaksi1 and others added 2 commits August 25, 2026 21:10
Nothing on the timeline screen says how large a room is, so it is easy to
forget whether a message is going to a handful of people or to a few
thousand. Opening the room details and coming back is the only way to
check.

The room's member count now sits under its name in the top bar, in the
same tappable area that already opens the room details. Direct messages
and spaces show nothing: the count is either obvious or meaningless
there.

Part of element-hq#3568
@hayaksi1
hayaksi1 requested a review from a team as a code owner August 25, 2026 18:29
@hayaksi1
hayaksi1 requested review from bmarty and removed request for a team August 25, 2026 18:29
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@CLAassistant

CLAassistant commented Aug 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 25, 2026
@bmarty bmarty added the X-Needs-Product Issue needs input from Product team label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

X-Needs-Product Issue needs input from Product team Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants