Show how many people are in a room under its name - #7568
Open
hayaksi1 wants to merge 3 commits into
Open
Conversation
Nothing on the timeline screen says how large a room is, so it is easy to forget whether a message is going to a handful of people or to a few thousand. Opening the room details and coming back is the only way to check. The room's member count now sits under its name in the top bar, in the same tappable area that already opens the room details. Direct messages and spaces show nothing: the count is either obvious or meaningless there. Part of element-hq#3568
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Nothing on the timeline screen says how large a room is, so it is easy to forget whether a message is going to a handful of people or to a few thousand. Opening the room details and coming back is the only way to check.
The room's member count now sits under its name in the top bar, in the same tappable area that already opens the room details, so the layout gains a line rather than a control. Direct messages and spaces show nothing: the count is either obvious or meaningless there.
Motivation and context
Relates to #3568.
Tests
MessagesPresenterTest— a group room reports its joined member count, a direct message reports none.These do not cover the count for a room whose members have not synced yet; the top bar then shows whatever count the room info carries, and updates when it changes.
Tested devices
Checklist