PR 3/3: Experimental Native Element Call behind lab flag

[BillCarsonFr]

Content

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• I am aware of the etiquette.
• This PR was made with the help of AI:
  • Yes. In this case, please request a review by Copilot.
  • No.
• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly defines what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZWcee2

[codecov]

Codecov Report

❌ Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/valere/native_call_stack@5b638a6). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
.../features/callnative/impl/DefaultNativeCallHost.kt	0.00%	20 Missing ⚠️
...roid/features/callnative/impl/ElementXCallStyle.kt	0.00%	7 Missing ⚠️
...features/callnative/impl/ElementCallControllers.kt	0.00%	6 Missing ⚠️
...d/features/callnative/impl/DefaultNativeCallPip.kt	0.00%	4 Missing ⚠️
...c/main/kotlin/io/element/android/x/MainActivity.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                         @@
##             feature/valere/native_call_stack    #7747   +/-   ##
===================================================================
  Coverage                                    ?   80.95%           
===================================================================
  Files                                       ?     2801           
  Lines                                       ?    82836           
  Branches                                    ?    11405           
===================================================================
  Hits                                        ?    67061           
  Misses                                      ?    11389           
  Partials                                    ?     4386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jmartinesp]

2 issues I found so far with PiP:

• When sending the call to background using the home button/gesture, the PiP window is at the bottom with the right aspect ratio, but when doing the same with the top left icon, it's always in landscape and at the top-right corner of the screen.
• When a call is ended through the notification, the PiP triggered from the home action is still visible - only that one, the one from the top-left icon works as expected -, displaying the chat screen in a creative way 😅 :

[BillCarsonFr]

• When sending the call to background using the home button/gesture, the PiP window is at the bottom with the right aspect ratio, but when doing the same with the top left icon, it's always in landscape and at the top-right corner of the screen.

The in app PIP is different from the system app, it is a custom one. I wanted to experiment on that to see if we could do some interesting interactions.
It is still very much experimental.
I can try to make it more usefull, leave as is, or descope?

[jmartinesp]

The in app PIP is different from the system app, it is a custom one. I wanted to experiment on that to see if we could do some interesting interactions. It is still very much experimental. I can try to make it more usefull, leave as is, or descope?

Oh, I didn't realise this one was in-app. I think the ideal solution would be to have both PiP windows behaving similarly (same position, use the other user's aspect ratio, etc.) but I'm not sure how feasible that is.

[BillCarsonFr]

@jmartinesp I bumped the element-call version to a new release.
Fixes the issues you saw https://github.com/element-hq/element-call-android/releases/tag/v0.1.0-rc.3

For now the in app floating call respect the video source ratio, but not position.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jmartinesp]

Thanks! I think this is good enough for an initial integration behind a feature flag, and the code seems OK.

[jmartinesp]

Double checking, but what we're doing is, instead of opening a new activity for EC, we're using MainActivity and overlaying EC on top of everything, right?

I'm a bit concerned this could cause issues with other UI elements, like pop ups or snackbars that could be displayed in a window on top of the current activity, but I can't think of anything at the moment that could cause this scenario.