fix(auth): resolve deduplicated OAuth callback redirects against base URL - #3329
Open
krzeznicki wants to merge 1 commit into
Open
fix(auth): resolve deduplicated OAuth callback redirects against base URL#3329krzeznicki wants to merge 1 commit into
krzeznicki wants to merge 1 commit into
Conversation
|
@krzeznicki is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3326
On self-hosted standalone deployments,
request.urlcarries the server's internal origin (e.g. the Docker container hostname), so the deduplicated OAuth callback response redirected users tohttps://<container-id>:3000/welcome-redirect(ERR_NAME_NOT_RESOLVED). better-auth returns a relativeLocation, which only breaks when the cached (second) response absolutizes it againstrequest.url.env.NEXT_PUBLIC_BASE_URLinstead ofrequest.urlrequestparam fromcreateCachedRedirectValidation:
pnpm test utils/oauth/auth-callback-deduplication.test.ts— 11 passed; the two new tests reproduced the container-origin redirect before the fix. No behavior change on Vercel, whererequest.urlandNEXT_PUBLIC_BASE_URLshare the same origin.