Add more tests

Author: warmwaffles

integration_test/precedence_test.exs

@@ -0,0 +1,63 @@
+defmodule Ecto.Integration.PrecedenceTest do
+  use Ecto.Integration.Case, async: true
+
+  alias Ecto.Integration.Post
+  alias Ecto.Integration.TestRepo
+  import Ecto.Query
+
+  @posted ~D[2014-01-01]
+  @inserted_at ~N[2014-01-01 02:00:00]
+
+  setup do
+    TestRepo.insert!(%Post{
+      posted: @posted,
+      inserted_at: @inserted_at,
+      visits: 1,
+      counter: 2,
+      public: true
+    })
+
+    :ok
+  end
+
+  test "datetime_add parenthesizes a compound day count" do
+    assert [~N[2014-01-04 02:00:00]] =
+             TestRepo.all(
+               from(p in Post, select: datetime_add(p.inserted_at, p.visits + p.counter, "day"))
+             )
+  end
+
+  test "datetime_add parenthesizes a compound week count" do
+    assert [~N[2014-01-22 02:00:00]] =
+             TestRepo.all(
+               from(p in Post, select: datetime_add(p.inserted_at, p.visits + p.counter, "week"))
+             )
+  end
+
+  test "datetime_add parenthesizes a compound millisecond count" do
+    TestRepo.delete_all(Post)
+
+    TestRepo.insert!(%Post{
+      posted: @posted,
+      inserted_at: @inserted_at,
+      visits: 500,
+      counter: 500
+    })
+
+    assert [~N[2014-01-01 02:00:01]] =
+             TestRepo.all(
+               from(p in Post,
+                 select: datetime_add(p.inserted_at, p.visits + p.counter, "millisecond")
+               )
+             )
+  end
+
+  test "date_add parenthesizes a compound day count" do
+    assert [~D[2014-01-04]] =
+             TestRepo.all(from(p in Post, select: date_add(p.posted, p.visits + p.counter, "day")))
+  end
+
+  test "is_nil parenthesizes not" do
+    assert [false] = TestRepo.all(from(p in Post, select: is_nil(not p.public)))
+  end
+end

test/ecto/adapters/sqlite3/connection/select_test.exs

@@ -480,6 +480,16 @@ defmodule Ecto.Adapters.SQLite3.Connection.SelectTest do
 
       assert ~s{SELECT 1 = (s0."x" IN (?,?,?)) FROM "schema" AS s0} == all(query)
     end
+
+    test "parenthesizes equality on the left of in" do
+      query =
+        Schema
+        |> select([e], (e.x == e.y) in [true, false])
+        |> plan()
+
+      assert ~s{SELECT (s0."x" = s0."y") IN (1,0) FROM "schema" AS s0} ==
+               all(query)
+    end
   end
 
   test "in subquery" do
@@ -515,6 +525,20 @@ defmodule Ecto.Adapters.SQLite3.Connection.SelectTest do
              ~s{))} == all(query)
   end
 
+  test "parenthesizes addition on the left of in subquery" do
+    posts = subquery("posts" |> where(title: ^"hello") |> select([p], p.id))
+
+    query =
+      "comments"
+      |> where([c], (c.x + c.y) in subquery(posts))
+      |> select([c], c.x)
+      |> plan()
+
+    assert all(query) ==
+             ~s{SELECT c0."x" FROM "comments" AS c0 } <>
+               ~s{WHERE ((c0."x" + c0."y") IN (SELECT sp0."id" FROM "posts" AS sp0 WHERE (sp0."title" = ?)))}
+  end
+
   describe "arrays" do
     test "array of integers fragment is not supported" do
       assert_raise Ecto.QueryError, fn ->