Make it more clear that we are maybe parenthesizing an expression

Author: warmwaffles

lib/ecto/adapters/sqlite3/connection.ex

@@ -860,7 +860,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
       quoted_key,
       " = ",
       quoted_key,
-      " + " | maybe_paren(value, sources, query)
+      " + " | maybe_paren_expr(value, sources, query)
     ]
   end
 
@@ -1189,7 +1189,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
 
   defp expr({:in, _, [left, right]}, sources, query) when is_list(right) do
     args = Enum.map_intersperse(right, ?,, &expr(&1, sources, query))
-    [maybe_paren(left, sources, query), " IN (", args, ?)]
+    [maybe_paren_expr(left, sources, query), " IN (", args, ?)]
   end
 
   defp expr({:in, _, [_, {:^, _, [_, 0]}]}, _sources, _query) do
@@ -1198,17 +1198,17 @@ defmodule Ecto.Adapters.SQLite3.Connection do
 
   defp expr({:in, _, [left, {:^, _, [_, len]}]}, sources, query) do
     args = Enum.intersperse(List.duplicate(??, len), ?,)
-    [maybe_paren(left, sources, query), " IN (", args, ?)]
+    [maybe_paren_expr(left, sources, query), " IN (", args, ?)]
   end
 
   defp expr({:in, _, [left, %Ecto.SubQuery{} = subquery]}, sources, query) do
-    [maybe_paren(left, sources, query), " IN ", expr(subquery, sources, query)]
+    [maybe_paren_expr(left, sources, query), " IN ", expr(subquery, sources, query)]
   end
 
   # Super Hack to handle arrays in json
   defp expr({:in, _, [left, right]}, sources, query) do
     [
-      maybe_paren(left, sources, query),
+      maybe_paren_expr(left, sources, query),
       " IN (SELECT value FROM JSON_EACH(",
       expr(right, sources, query),
       ?),
@@ -1217,7 +1217,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   defp expr({:is_nil, _, [arg]}, sources, query) do
-    [maybe_paren(arg, sources, query) | " IS NULL"]
+    [maybe_paren_expr(arg, sources, query) | " IS NULL"]
   end
 
   defp expr({:not, _, [expression]}, sources, query) do
@@ -1477,7 +1477,7 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   defp fragment_expr(parts, sources, query) do
     Enum.map(parts, fn
       {:raw, part} -> part
-      {:expr, expr} -> maybe_paren(expr, sources, query)
+      {:expr, expr} -> maybe_paren_expr(expr, sources, query)
     end)
     |> parens_for_select()
   end
@@ -1488,19 +1488,19 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   end
 
   defp interval(count, "millisecond", sources, query) do
-    [?(, maybe_paren(count, sources, query), " / 1000.0) || ' seconds'"]
+    [?(, maybe_paren_expr(count, sources, query), " / 1000.0) || ' seconds'"]
   end
 
   defp interval(count, "week", sources, query) do
-    [?(, maybe_paren(count, sources, query), " * 7) || ' days'"]
+    [?(, maybe_paren_expr(count, sources, query), " * 7) || ' days'"]
   end
 
   defp interval(count, interval, sources, query) do
-    [maybe_paren(count, sources, query), " || ' ", interval, "'"]
+    [maybe_paren_expr(count, sources, query), " || ' ", interval, "'"]
   end
 
   defp op_to_binary(expression, sources, query) do
-    maybe_paren(expression, sources, query)
+    maybe_paren_expr(expression, sources, query)
   end
 
   def create_names(query) do
@@ -1750,23 +1750,24 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   defp reference_on_update(:restrict), do: " ON UPDATE RESTRICT"
   defp reference_on_update(_), do: []
 
-  defp maybe_paren({op, _, [_, _]} = expr, sources, query) when op in @binary_ops do
+  defp maybe_paren_expr({op, _, [_, _]} = expr, sources, query)
+       when op in @binary_ops do
     paren_expr(expr, sources, query)
   end
 
-  defp maybe_paren({:is_nil, _, [_]} = expr, sources, query) do
+  defp maybe_paren_expr({:is_nil, _, [_]} = expr, sources, query) do
     paren_expr(expr, sources, query)
   end
 
-  defp maybe_paren({:not, _, [_]} = expr, sources, query) do
+  defp maybe_paren_expr({:not, _, [_]} = expr, sources, query) do
     paren_expr(expr, sources, query)
   end
 
-  defp maybe_paren({:in, _, [_, _]} = expr, sources, query) do
+  defp maybe_paren_expr({:in, _, [_, _]} = expr, sources, query) do
     paren_expr(expr, sources, query)
   end
 
-  defp maybe_paren(expr, sources, query) do
+  defp maybe_paren_expr(expr, sources, query) do
     expr(expr, sources, query)
   end