Recents refactor - #602
Open
ricardoricho wants to merge 5 commits into
Open
Conversation
jcs090218
reviewed
Apr 11, 2026
| :load-path "./" | ||
| :demand t) | ||
| (with-current-buffer (dashboard-open) | ||
| (should (string-match-p "Welcome to Emacs!" (buffer-string))))) |
Member
There was a problem hiding this comment.
We would need to manually install use-package for early Emacs versions.
| $(EASK) test ert ./test/*.el | ||
|
|
||
| test-activate: package install | ||
| $(EASK) emacs --batch -l ./test/activate.el |
Member
There was a problem hiding this comment.
Might just replace this with ert tests?
ricardoricho
force-pushed
the
recents-refactor
branch
from
May 9, 2026 18:28
6948ea6 to
c88a49f
Compare
Member
Author
|
Hi @jcs090218 I think we are ready to merge/squash this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor of the "recents" section. It changes the way we keep a copy of
recentf-listbefore we visit all the files involved in the construction of the different sections and then restore the list to remove all the pollution of the construction.One part I'm not sure of is that if
recentf-modeis not enable, do we have toenable it? In the current implementation we are activating the mode to read the
list, but there is
recetf-load-listthat do that without activating the mode.I added some test just for this section, but I expect that this will be the
pattern, to have test files for each section and test some features instead of
testing each function. What do you think?