feat(simulator): render every panel and chart through ui-cpp (#332)

* feat(simulator): render the FFT and PSD panels through ui-cpp

Both panels become Qt-free field descriptions: two combos and a sample
rate for FFT, five spectrum fields plus a noise group for PSD, with the
shared signal-component table in place of SignalConfigWidget.

PSD carried the conditional-enable bug the form model fixes structurally.
Its noise handler was connected after the initial selection was set, so
the amplitude control's enablement was never synchronised at startup; it
only looked right because the default noise type happened to be the one
that enables it. Conditions now apply at build time and on every change
through the same path, and a test pins the starting state.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* feat(simulator): render the PID, MPC and LQR panels through ui-cpp

PID is the group-swapping case: the two plant parameterisations become
groups with a selection condition instead of two setVisible calls made
from a handler wired after the initial selection. Its root-locus drag
writes Kp back through the model and refreshes the one control, which is
what the view's re-entrancy flag exists for; the write is clamped to the
field's own range so the model cannot hold a value the spin box would
have rejected.

LQR's three composite monospace state lines become five read-out fields.
The content is the same and the angles are still converted to degrees for
display only, but each value now gets its own labelled row rather than
sharing a formatted line, since a read-out states one number.

Its five buttons take semantic roles (Start, Stop, Reset) rather than the
uniform default styling the panel gave them, and CartPoleWidget and
LqrEvaluationWidget stay as they are, handed to the shell as bare
QWidget* through the native-page escape hatch.

Also dropped PidMainWindow::pendingGain, which was assigned on every drag
and never read.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* feat(simulator): render the RLS, Kalman and Bayesian MPC panels through ui-cpp

The last three panels, which completes the migration: every one of the
eleven applications now describes its parameters rather than building
them, and simulator/widgets/SignalConfigWidget is deleted with the last
consumer that referenced it.

RLS keeps its three coefficients as three separate fields rather than
gaining a fixed-arity array field for one call site, and its compute path
gains the guard it never had - it was the only application with no
try/catch around the simulation at all.

Bayesian MPC's word-wrapped status label inside the panel becomes the
shell's status line, which is where the other ten applications already
report. Its run button still disables itself for the duration, now
through the view rather than by holding the widget.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* style(simulator): format the status-line chains in every main window

clang-format wants a different continuation indent for QString().arg()
chains than the eleven windows carried. Applied to all of them, including
the three migrated earlier, so the set reads the same and the tree is
format-clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* feat(simulator): render the filter charts through ui-cpp

IIR, FIR and Kalman drop the vendored chart widgets for ChartCore hosted
in QtPaintedWidget, which is what the FFT application has done since the
stop-gate.

The impulse response of both filters plots a sample index, and the widget
it replaces hardcoded "Time (s)" as its X-axis title whatever it was fed.
LinearAxis takes that title as a parameter, so the two impulse charts now
say "Sample" and read back "n = " at the cursor.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* feat(simulator): render the PSD, LQG, MPC and PID charts through ui-cpp

Four more applications move onto ChartCore. PID keeps PidRootLocusWidget
as a native page beside three portable ones, which is what SetPage taking
a bare QWidget* is for.

MPC's per-state series names were built with QString::arg purely to make
a QString the chart wanted; ui::charts::Series takes std::string, so they
are std::format now and the window keeps one fewer Qt type in its inner
loop.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* feat(simulator): render the RLS, Bayesian MPC and LQR evaluation charts through ui-cpp

The last three, and the ones the hardcoded axis title mislabelled worst.
RLS plots a sample index on all three of its charts and Bayesian MPC
plots an EM iteration on one and a BO evaluation on another; all five
said "Time (s)". They now say "Sample", "Iteration" and "Evaluation",
and the cursor reads back "n = " or "i = " to match.

LqrEvaluationWidget composes two charts rather than being one, so it
becomes a QWidget holding two QtPaintedWidgets and stays a native page
handed to the shell.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* refactor(simulator): delete the vendored chart widgets

Nothing references simulator/widgets any more, so the 1287 lines it held
go with the numerical.simulator.widgets target: TimeSeriesChartWidget,
FrequencyChartWidget and the ChartInteraction they shared, all of which
ui/charts now provides once for every consumer.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YQEnuDHtCQb5UyddnMup3Q

* Apply batched suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update simulator/filters/KalmanFilter/view/KalmanMainWindow.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 3 people

simulator/CMakeLists.txt

@@ -1,6 +1,5 @@
 add_subdirectory(utils)
 add_subdirectory(shell)
-add_subdirectory(widgets)
 add_subdirectory(analysis)
 add_subdirectory(controllers)
 add_subdirectory(estimators)

simulator/analysis/FastFourierTransform/CMakeLists.txt

@@ -9,6 +9,7 @@ emil_build_for(numerical.simulator.analysis.fast_fourier_transform HOST All PRER
 target_link_libraries(numerical.simulator.analysis.fast_fourier_transform PRIVATE
     numerical.simulator.analysis.fft.application
     numerical.simulator.analysis.fft.view
+    numerical.simulator.shell.qt
 )
 
 target_sources(numerical.simulator.analysis.fast_fourier_transform PRIVATE

simulator/analysis/FastFourierTransform/Main.cpp

@@ -1,15 +1,7 @@
 #include "simulator/analysis/FastFourierTransform/view/FftMainWindow.hpp"
-#include "ui/backend/qt/QtTheme.hpp"
-#include <QApplication>
+#include "simulator/shell/AppRunner.hpp"
 
 int main(int argc, char* argv[])
 {
-    QApplication app(argc, argv);
-
-    ui::backend::qt::ApplyTheme(ui::theme::Light());
-
-    simulator::analysis::view::FftMainWindow window;
-    window.show();
-
-    return app.exec();
+    return simulator::shell::Run<simulator::analysis::view::FftMainWindow>(argc, argv, ui::theme::Light());
 }

simulator/analysis/FastFourierTransform/application/CMakeLists.txt

@@ -9,11 +9,15 @@ target_link_libraries(numerical.simulator.analysis.fft.application PUBLIC
     numerical.analysis
     numerical.analysis.windowing
     numerical.simulator.utils
+    numerical.simulator.shell
+    ui.model
 )
 
 target_sources(numerical.simulator.analysis.fft.application PRIVATE
     FftSimulator.cpp
     FftSimulator.hpp
+    FftForm.cpp
+    FftForm.hpp
 )
 
 if(MSVC)
@@ -23,3 +27,7 @@ else()
         -Wno-error
     )
 endif()
+
+if (NUMERICAL_TOOLBOX_BUILD_TESTS)
+    add_subdirectory(test)
+endif()

simulator/analysis/FastFourierTransform/application/FftForm.cpp

@@ -0,0 +1,83 @@
+#include "simulator/analysis/FastFourierTransform/application/FftForm.hpp"
+
+namespace simulator::analysis
+{
+    namespace
+    {
+        using ui::model::ActionSpec;
+        using ui::model::FieldKind;
+        using ui::model::FieldSpec;
+        using ui::model::GroupSpec;
+        using ui::model::OptionSpec;
+
+        constexpr std::array<OptionSpec, 7> fftSizes{
+            OptionSpec{ "64", 64 },
+            OptionSpec{ "128", 128 },
+            OptionSpec{ "256", 256 },
+            OptionSpec{ "512", 512 },
+            OptionSpec{ "1024", 1024 },
+            OptionSpec{ "2048", 2048 },
+            OptionSpec{ "4096", 4096 }
+        };
+
+        constexpr std::array<OptionSpec, 4> windowTypes{
+            OptionSpec{ "Rectangular", static_cast<std::int64_t>(WindowType::Rectangular) },
+            OptionSpec{ "Hamming", static_cast<std::int64_t>(WindowType::Hamming) },
+            OptionSpec{ "Hanning", static_cast<std::int64_t>(WindowType::Hanning) },
+            OptionSpec{ "Blackman", static_cast<std::int64_t>(WindowType::Blackman) }
+        };
+
+        constexpr std::array<GroupSpec, 2> groups{
+            GroupSpec{ field::transform, "FFT Configuration", {} },
+            GroupSpec{ field::signal, "Signal Components", {} }
+        };
+
+        constexpr std::array<FieldSpec, 3> fields{
+            FieldSpec{ field::fftSize, field::transform, FieldKind::Choice, "FFT Size:", "", {}, fftSizes, {}, {} },
+            FieldSpec{ field::sampleRate, field::transform, FieldKind::Number, "Sample Rate (Hz):", " Hz", { 100.0, 192000.0, 1.0, 44100.0, 1 }, {}, {}, {} },
+            FieldSpec{ field::windowType, field::transform, FieldKind::Choice, "Window:", "", {}, windowTypes, {}, {} }
+        };
+
+        constexpr std::array<ActionSpec, 1> actions{
+            ActionSpec{ field::compute, "Compute FFT", ui::theme::ButtonRole::Primary, 40 }
+        };
+
+        constexpr std::array<utils::SignalComponent, 3> defaultComponents{
+            utils::SignalComponent{ 1000.0f, 0.15f },
+            utils::SignalComponent{ 5000.0f, 0.5f },
+            utils::SignalComponent{ 12000.0f, 0.25f }
+        };
+    }
+
+    FftForm::FftForm()
+        : tableSpecs{ ui::model::TableSpec{ field::signal, shell::signalColumns, maximumComponents, "Add", "Remove" } }
+        , tables{ ui::model::TableModel{ tableSpecs[0], cells } }
+        , spec{ groups, fields, actions, tableSpecs }
+        , model{ spec, values, tables }
+    {
+        model.SelectByData(field::fftSize, 1024);
+        shell::SeedFrom(defaultComponents, tables[0]);
+    }
+
+    ui::model::FormModel& FftForm::Model()
+    {
+        return model;
+    }
+
+    const ui::model::FormModel& FftForm::Model() const
+    {
+        return model;
+    }
+
+    FftSimulator::Configuration FftForm::BuildConfiguration() const
+    {
+        FftSimulator::Configuration config;
+
+        config.fftSize = static_cast<std::size_t>(model.SelectedData(field::fftSize));
+        config.sampleRateHz = model.Float(field::sampleRate);
+        config.windowType = static_cast<WindowType>(model.SelectedData(field::windowType));
+        config.signalComponents = shell::ToComponents(model.Table(0));
+
+        return config;
+    }
+}

simulator/analysis/FastFourierTransform/application/FftForm.hpp

@@ -0,0 +1,44 @@
+#pragma once
+
+#include "simulator/analysis/FastFourierTransform/application/FftSimulator.hpp"
+#include "simulator/shell/SignalComponents.hpp"
+#include "ui/model/FormModel.hpp"
+#include <array>
+
+namespace simulator::analysis
+{
+    namespace field
+    {
+        inline constexpr ui::model::FieldId fftSize{ 1 };
+        inline constexpr ui::model::FieldId sampleRate{ 2 };
+        inline constexpr ui::model::FieldId windowType{ 3 };
+
+        inline constexpr ui::model::GroupId transform{ 1 };
+        inline constexpr ui::model::GroupId signal{ 2 };
+
+        inline constexpr ui::model::ActionId compute{ 1 };
+    }
+
+    class FftForm
+    {
+    public:
+        FftForm();
+
+        [[nodiscard]] ui::model::FormModel& Model();
+        [[nodiscard]] const ui::model::FormModel& Model() const;
+
+        [[nodiscard]] FftSimulator::Configuration BuildConfiguration() const;
+
+    private:
+        static constexpr std::size_t fieldCount{ 3 };
+        static constexpr std::size_t maximumComponents{ 16 };
+
+        std::array<ui::model::TableSpec, 1> tableSpecs;
+        std::array<double, maximumComponents * 2> cells{};
+        std::array<ui::model::TableModel, 1> tables;
+        std::array<ui::model::FieldValue, fieldCount> values{};
+
+        ui::model::FormSpec spec;
+        ui::model::FormModel model;
+    };
+}

simulator/analysis/FastFourierTransform/application/test/CMakeLists.txt

@@ -0,0 +1,12 @@
+add_executable(numerical.simulator.analysis.fft.application_test)
+emil_build_for(numerical.simulator.analysis.fft.application_test HOST All PREREQUISITE_BOOL NUMERICAL_TOOLBOX_BUILD_SIMULATOR)
+emil_add_test(numerical.simulator.analysis.fft.application_test)
+
+target_link_libraries(numerical.simulator.analysis.fft.application_test PUBLIC
+    gmock_main
+    numerical.simulator.analysis.fft.application
+)
+
+target_sources(numerical.simulator.analysis.fft.application_test PRIVATE
+    TestFftForm.cpp
+)

simulator/analysis/FastFourierTransform/application/test/TestFftForm.cpp

@@ -0,0 +1,73 @@
+#include "simulator/analysis/FastFourierTransform/application/FftForm.hpp"
+#include <gmock/gmock.h>
+
+namespace
+{
+    using simulator::analysis::FftForm;
+    namespace field = simulator::analysis::field;
+
+    class FftFormTest
+        : public ::testing::Test
+    {
+    protected:
+        FftForm form;
+    };
+}
+
+TEST_F(FftFormTest, TheDefaultsMatchThePanelThisReplaced)
+{
+    const auto config = form.BuildConfiguration();
+
+    EXPECT_EQ(config.fftSize, 1024u);
+    EXPECT_NEAR(config.sampleRateHz, 44100.0f, 1e-3f);
+    EXPECT_EQ(config.windowType, simulator::analysis::WindowType::Rectangular);
+}
+
+TEST_F(FftFormTest, TheDefaultSizeIsSelectedByItsValueNotItsPosition)
+{
+    EXPECT_EQ(form.Model().Selection(field::fftSize), 4u);
+}
+
+TEST_F(FftFormTest, EverySupportedSizeIsOfferedAndReadsBackAsItself)
+{
+    const auto sizes = simulator::analysis::FftSimulator::SupportedFftSizes();
+    ASSERT_EQ(form.Model().Field(field::fftSize).options.size(), sizes.size());
+
+    for (std::size_t i = 0; i < sizes.size(); ++i)
+    {
+        form.Model().SetSelection(field::fftSize, i);
+        EXPECT_EQ(form.BuildConfiguration().fftSize, sizes[i]);
+    }
+}
+
+TEST_F(FftFormTest, TheWindowTypeComesFromTheOptionDataNotItsPosition)
+{
+    form.Model().SetSelection(field::windowType, 3);
+
+    EXPECT_EQ(form.BuildConfiguration().windowType, simulator::analysis::WindowType::Blackman);
+}
+
+TEST_F(FftFormTest, TheSignalComponentsAreSeededAsThePanelSeededThem)
+{
+    const auto config = form.BuildConfiguration();
+
+    ASSERT_EQ(config.signalComponents.size(), 3u);
+    EXPECT_NEAR(config.signalComponents[0].frequencyHz, 1000.0f, 1e-3f);
+    EXPECT_NEAR(config.signalComponents[0].amplitude, 0.15f, 1e-4f);
+    EXPECT_NEAR(config.signalComponents[1].frequencyHz, 5000.0f, 1e-3f);
+    EXPECT_NEAR(config.signalComponents[1].amplitude, 0.5f, 1e-4f);
+    EXPECT_NEAR(config.signalComponents[2].frequencyHz, 12000.0f, 1e-3f);
+    EXPECT_NEAR(config.signalComponents[2].amplitude, 0.25f, 1e-4f);
+}
+
+TEST_F(FftFormTest, EditingTheTableReachesTheConfiguration)
+{
+    auto& table = form.Model().Table(0);
+    table.SetCell(1, 0, 6000.0);
+    table.SetCell(1, 1, 0.75);
+
+    const auto config = form.BuildConfiguration();
+
+    EXPECT_NEAR(config.signalComponents[1].frequencyHz, 6000.0f, 1e-3f);
+    EXPECT_NEAR(config.signalComponents[1].amplitude, 0.75f, 1e-4f);
+}

simulator/analysis/FastFourierTransform/view/CMakeLists.txt

@@ -7,7 +7,7 @@ target_include_directories(numerical.simulator.analysis.fft.view PUBLIC
 
 target_link_libraries(numerical.simulator.analysis.fft.view PUBLIC
     numerical.simulator.analysis.fft.application
-    numerical.simulator.widgets
+    numerical.simulator.shell
     ui.charts
     ui.backend.qt
     Qt6::Widgets
@@ -18,8 +18,6 @@ set_target_properties(numerical.simulator.analysis.fft.view PROPERTIES
 )
 
 target_sources(numerical.simulator.analysis.fft.view PRIVATE
-    FftConfigurationPanel.cpp
-    FftConfigurationPanel.hpp
     FftMainWindow.cpp
     FftMainWindow.hpp
 )