Repository navigation
feat(localization): add ScanMatcher (E5) - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014WUWh44uw7k4JjMd6YkAwN
2-D ICP between laser scans with gated brute-force nearest-neighbour association. The point-to-point step is the weighted planar PointSetAlignment; the point-to-line step runs Levenberg-Marquardt on the normal distances with SE(2) left retraction, after an eigenvalue-ratio check of J^T J refuses corridor-like degenerate geometry. Normals come from the nearest reference segment, skipping segments longer than the correspondence gate so wall junctions in scan order and duplicate corner points cannot produce bogus normals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014WUWh44uw7k4JjMd6YkAwN
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014WUWh44uw7k4JjMd6YkAwN
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 7 | 0 | 0 | 0.68s | ||
| ✅ CPP | clang-format | 204 | 0 | 0 | 0 | 2.15s | |
| ✅ CPP | cppcheck | 204 | 0 | 0 | 4.5s | ||
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.69s | ||
| ✅ JSON | jsonlint | 8 | 0 | 0 | 0.11s | ||
| ✅ JSON | prettier | 8 | 2 | 0 | 0 | 0.46s | |
| ✅ MARKDOWN | markdownlint | 88 | 0 | 0 | 0 | 2.48s | |
| ✅ MARKDOWN | markdown-table-formatter | 88 | 0 | 0 | 0 | 0.26s | |
| lychee | 135 | 2 | 0 | 2.49s | |||
| ✅ YAML | prettier | 12 | 0 | 0 | 0 | 0.57s | |
| ✅ YAML | yamllint | 12 | 0 | 0 | 0.59s |
Detailed Issues
⚠️ SPELL / lychee - 2 errors
[ERROR] failed to verify TLS certificate: invalid peer certificate: UnknownIssuer
📝 Summary
---------------------
🔍 Total..........361
🔗 Unique.........128
✅ Successful.....349
⏳ Timeouts.........0
🔀 Redirected.......5
👻 Excluded.........9
❓ Unknown..........0
🚫 Errors...........2
⛔ Unsupported......2
Errors in .github/workflows/static-analysis.yml
[403] https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$ (at 37:21) | Rejected status code: 403 Forbidden
Errors in doc/kinematics/InverseKinematics.md
[ERROR] https://mathweb.ucsd.edu/~sbuss/ResearchWeb/ikmethods/iksurvey.pdf (at 125:169) | SSL certificate not trusted. Use --insecure if site is trusted
Hint: Followed 5 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
Notices
REPOSITORY_GITLEAKS, REPOSITORY_KICS. See Removed linters to find their replacements.
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT

Show us your support by starring ⭐ the repository
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Bumps numerical-toolbox to
182e068, which brings inPointSetAlignment(NT67, embedded-pro/numerical-toolbox-cpp#368). Then it ships E5, the 2-D scan matcher that NT67 unblocked.ff2e14b+6de0285182e068.eddd41bScanMatcher: point-to-point and point-to-line ICP between laser scans.The E5 commit includes the header, coverage
.cpp, the spec's 6 tests, doc, index rows, and removal of the spec and its roadmap rows.robotics.localizationnow linksnumerical.solverandnumerical.optimization.E5 in short
maxCorrespondenceDistance. Pairs outside the gate get zero weight.PointSetAlignment(NT67).LeastSquaresProblemon the normal distances, solved withLevenbergMarquardtandConstantDamping(NT64) using SE(2) left retraction.JᵀJ(JacobiEigenSolver) are checked. A ratio below1e-6, as in a corridor, makesMatchreturnnullopt.Deviations from the spec
j − 1/j + 1") picks the wrong wall in single precision. That happens at the room's duplicated corner point, and at the junction where scan order jumps from one wall to the next (a bogus diagonal "segment").currentscan larger thanMaxPointsis refused.maxIterations = 1reportsconverged == false.IcpMetricenumerators are PascalCase (PointToPoint,PointToLine), as in earlier waves.λ² > 0, the LM normal matrix is always positive definite, so a failed step cannot happen and is not checked.Verification
ctest: 7/7.ScanMatcher.hpp.-Wall -Wextra -Werror -Wshadowwith-DROBOTICS_TOOLBOX_COVERAGE_BUILD.clang-format.validate-docsOK; no doc line over 400 characters; tables aligned.Generated by Claude Code