Fix unused and overly-broad __deps entries in JS libraries

- In `src/lib/libpthread.js`, guard `'$addOnPreRun'` in `$PThread__deps`
  with `#if !MINIMAL_RUNTIME && PTHREAD_POOL_SIZE`.
- Guard or remove other unused and overly-broad `__deps` entries across
  `src/lib/*.js` (`libasync.js`, `libbrowser.js`, `libdylink.js`,
  `libemval.js`, `libfetch.js`, `libfs.js`, `libglew.js`,
  `libglut.js`, `libhtml5.js`, `libnoderawfs.js`, `libsdl.js`,
  `libsockfs_node.js`, `libwasmfs.js`).

Split out from #27995

Author: sbc100

src/lib/libasync.js

@@ -21,14 +21,15 @@ addToLibrary({
 
 #if ASYNCIFY
   $Asyncify__force: true,
-  $Asyncify__deps: ['$runAndAbortIfError', '$callUserCallback',
-#if ASSERTIONS
-    '$createNamedFunction',
-#endif
-#if !MINIMAL_RUNTIME
+  $Asyncify__deps: [
+#if useRuntimeKeepaliveStack()
     '$runtimeKeepalivePush', '$runtimeKeepalivePop',
 #endif
 #if ASYNCIFY == 1
+    '$runAndAbortIfError', '$callUserCallback',
+#if ASSERTIONS
+    '$createNamedFunction',
+#endif
     // Needed by allocateData and handleSleep respectively
     'malloc', 'free',
 #endif

src/lib/libbrowser.js

@@ -577,7 +577,14 @@ var LibraryBrowser = {
   },
 
   // TODO: currently not callable from a pthread, but immediately calls onerror() if not on main thread.
-  emscripten_async_load_script__deps: ['$UTF8ToString', '$runDependencies', '$resolveRunDependencies', '$callUserCallback'],
+  emscripten_async_load_script__deps: [
+    '$UTF8ToString',
+#if ASSERTIONS
+    '$runDependencies',
+#endif
+    '$resolveRunDependencies',
+    '$callUserCallback',
+  ],
   emscripten_async_load_script: async (url, onload, onerror) => {
     url = UTF8ToString(url);
 #if PTHREADS

src/lib/libdylink.js

@@ -108,8 +108,9 @@ var LibraryDylink = {
   // the canonical name of the symbol (in some cases modifying the symbol as
   // part of the loop process, so that actual symbol looked up has a different
   // name).
-  $resolveGlobalSymbol__deps: ['$isSymbolDefined', '$createNamedFunction',
+  $resolveGlobalSymbol__deps: ['$isSymbolDefined',
 #if !DISABLE_EXCEPTION_CATCHING || SUPPORT_LONGJMP == 'emscripten'
+    '$createNamedFunction',
     '$createInvokeFunction',
 #endif
   ],
@@ -392,7 +393,7 @@ var LibraryDylink = {
   // Allocate memory even if malloc isn't ready yet.  The allocated memory here
   // must be zero initialized since its used for all static data, including bss.
   $getMemory__noleakcheck: true,
-  $getMemory__deps: ['$GOT', 'emscripten_get_sbrk_ptr', '__heap_base', '$alignMemory', 'calloc'],
+  $getMemory__deps: ['emscripten_get_sbrk_ptr', '__heap_base', '$alignMemory', 'calloc'],
   $getMemory: (size) => {
     // After the runtime is initialized, we must only use sbrk() normally.
 #if DYLINK_DEBUG
@@ -1015,9 +1016,7 @@ var LibraryDylink = {
     '_emscripten_find_dylib',
     '$withStackSave',
     '$stackAlloc',
-    '$lengthBytesUTF8',
     '$stringToUTF8OnStack',
-    '$stringToUTF8',
     '$FS',
     '$PATH',
 #if WASMFS

src/lib/libemval.js

@@ -361,7 +361,7 @@ ${functionBody}
     return emval_addMethodCaller(createNamedFunction(functionName, invokerFunction));
   },
 
-  _emval_invoke__deps: ['$getStringOrSymbol', '$emval_methodCallers', '$Emval'],
+  _emval_invoke__deps: ['$emval_methodCallers'],
   _emval_invoke: (caller, handle, methodName, destructorsRef, args) => {
     return emval_methodCallers[caller](handle, methodName, destructorsRef, args);
   },
@@ -410,7 +410,6 @@ ${functionBody}
   },
 
 #if !DISABLE_EXCEPTION_CATCHING || WASM_EXCEPTIONS
-  $isCppExceptionObject__deps: ['$Emval'],
   $isCppExceptionObject: (object) => {
 #if !DISABLE_EXCEPTION_CATCHING
     return object instanceof CppException;
@@ -420,12 +419,12 @@ ${functionBody}
   },
 #endif
 
+#if !DISABLE_EXCEPTION_CATCHING || WASM_EXCEPTIONS
   _emval_is_catchable_cpp_exception_object__deps: [
     '$Emval',
-#if !DISABLE_EXCEPTION_CATCHING || WASM_EXCEPTIONS
     '$isCppExceptionObject',
-#endif
   ],
+#endif
   _emval_is_catchable_cpp_exception_object: (object) => {
 #if !DISABLE_EXCEPTION_CATCHING || WASM_EXCEPTIONS
     return isCppExceptionObject(Emval.toValue(object));

src/lib/libfetch.js

@@ -18,7 +18,7 @@ var LibraryFetch = {
   $Fetch: Fetch,
   _emscripten_fetch_get_response_headers_length__deps: ['$lengthBytesUTF8'],
   _emscripten_fetch_get_response_headers_length: fetchGetResponseHeadersLength,
-  _emscripten_fetch_get_response_headers__deps: ['$lengthBytesUTF8', '$stringToUTF8'],
+  _emscripten_fetch_get_response_headers__deps: ['$stringToUTF8'],
   _emscripten_fetch_get_response_headers: fetchGetResponseHeaders,
   emscripten_fetch_free: fetchFree,
 

src/lib/libfs.js

@@ -30,7 +30,10 @@ var LibraryFS = {
     '$PROXYFS',
 #endif
 #if ASSERTIONS
-    '$strError', '$ERRNO_CODES', '$warnOnce',
+    '$strError', '$ERRNO_CODES',
+#if !STRICT
+    '$warnOnce',
+#endif
 #endif
 #if !MINIMAL_RUNTIME
     '$FS_createPreloadedFile',

src/lib/libglew.js

@@ -20,7 +20,7 @@
  */
 
 var LibraryGLEW = {
-  $GLEW__deps: ['glGetString', '$stringToNewUTF8', '$UTF8ToString', '$webglGetExtensions'],
+  $GLEW__deps: ['glGetString', '$stringToNewUTF8', '$webglGetExtensions'],
   $GLEW: {
     isLinaroFork: 1,
     extensions: null,

src/lib/libglut.js

@@ -582,7 +582,6 @@ var LibraryGLUT = {
   },
 
   glutDestroyWindow__proxy: 'sync',
-  glutDestroyWindow__deps: ['$Browser'],
   glutDestroyWindow: (name) => {
     delete Module['ctx'];
     return 1;
@@ -601,7 +600,7 @@ var LibraryGLUT = {
   },
 
   glutPositionWindow__proxy: 'sync',
-  glutPositionWindow__deps: ['$GLUT', 'glutPostRedisplay'],
+  glutPositionWindow__deps: ['$Browser', 'glutPostRedisplay'],
   glutPositionWindow: (x, y) => {
     Browser.exitFullscreen();
     /* TODO */

src/lib/libhtml5.js

@@ -9,7 +9,9 @@ var LibraryHTML5 = {
 #if PTHREADS
     '_emscripten_run_callback_on_thread',
 #endif
+#if EXIT_RUNTIME
     '$addOnExit',
+#endif
   ],
   $JSEvents: {
 
@@ -1418,7 +1420,11 @@ var LibraryHTML5 = {
     return doRequestFullscreen(target, strategy);
   },
 
-  emscripten_enter_soft_fullscreen__deps: ['$JSEvents', '$hideEverythingExceptGivenElement', '$restoreOldWindowedStyle', '$restoreHiddenElements', '$currentFullscreenStrategy', '$softFullscreenResizeWebGLRenderTarget', '$JSEvents_resizeCanvasForFullscreen', '$findEventTarget', '$callCanvasResizedCallback'],
+  emscripten_enter_soft_fullscreen__deps: [
+#if PTHREADS
+    '$JSEvents',
+#endif
+    '$hideEverythingExceptGivenElement', '$restoreOldWindowedStyle', '$restoreHiddenElements', '$currentFullscreenStrategy', '$softFullscreenResizeWebGLRenderTarget', '$JSEvents_resizeCanvasForFullscreen', '$findEventTarget', '$callCanvasResizedCallback'],
   emscripten_enter_soft_fullscreen__proxy: 'sync',
   emscripten_enter_soft_fullscreen: (target, fullscreenStrategy) => {
 #if !DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR

src/lib/libnoderawfs.js

@@ -5,7 +5,7 @@
  */
 
 addToLibrary({
-  $NODERAWFS__deps: ['$ERRNO_CODES', '$FS', '$NODEFS', '$TTY', '$mmapAlloc', '$FS_modeStringToFlags', '$NODERAWFS_stream_funcs'],
+  $NODERAWFS__deps: ['$ERRNO_CODES', '$FS', '$NODEFS', '$TTY', '$FS_modeStringToFlags', '$NODERAWFS_stream_funcs'],
   $NODERAWFS__postset: `
     if (!ENVIRONMENT_IS_NODE) {
       throw new Error('NODERAWFS is currently only supported on Node.js environment.')
@@ -220,6 +220,7 @@ addToLibrary({
    * could either be a stream created by NODERAWFS itself, or, for example
    * one created by PIPEFS.  We wrap all these function in an extra check.
    */
+  $NODERAWFS_stream_funcs__deps: ['$mmapAlloc'],
   $NODERAWFS_stream_funcs: {
     close(stream) {
       VFS.closeStream(stream.fd);