Skip to content

[GL] Prefix internal WebGL functions with an underscore - #27998

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:webgl-internal-prefix
Oct 20, 2026
Merged

sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:webgl-internal-prefix

Conversation

@sbc100

@sbc100 sbc100 commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Prefix internal WebGL helper functions (_emscripten_webgl_do_*, _emscripten_webgl_make_context_current_calling_thread, and _emscripten_webgl_create_context_proxied) with a leading underscore to make it clear that they are internal symbols.

@sbc100
sbc100 requested review from juj and kripken October 16, 2026 20:14
@sbc100
sbc100 enabled auto-merge (squash) October 16, 2026 20:29
@sbc100
sbc100 force-pushed the webgl-internal-prefix branch from a473753 to a2cfd02 Compare October 19, 2026 05:53
Prefix internal WebGL helper functions (`_emscripten_webgl_do_*`,
`_emscripten_webgl_make_context_current_calling_thread`, and
`_emscripten_webgl_create_context_proxied`) with a leading underscore
to make it clear that they are internal symbols.
@sbc100
sbc100 force-pushed the webgl-internal-prefix branch from a2cfd02 to c35cdb3 Compare October 20, 2026 19:05
@sbc100
sbc100 disabled auto-merge October 20, 2026 19:20
@sbc100
sbc100 merged commit 0306168 into emscripten-core:main Oct 20, 2026
20 of 24 checks passed
@sbc100
sbc100 deleted the webgl-internal-prefix branch October 20, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants