[WIP] bazel: Add compdb extractor - #42428
Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
cc @tsaarni |
| envoy_dependencies_extra() | ||
|
|
||
| load("@hedron_compile_commands//:workspace_setup_transitive.bzl", "hedron_compile_commands_setup_transitive") | ||
| hedron_compile_commands_setup_transitive() |
There was a problem hiding this comment.
these dont want to be here - but we are going to struggle to fit all of these into our current workspace fun
There was a problem hiding this comment.
Are you sure this transitives bring anything ? I thought they were empty
There was a problem hiding this comment.
not sure - just followed the docs
There was a problem hiding this comment.
I believe you can remove those imports they are noops
|
How should I run this? I get the same error that I had when I tried this myself: |
|
yeah - this is a bug in their setup (hedronvision/bazel-compile-commands-extractor#168 (comment)) for some reason they switched to rules_python a couple of years ago and the reverted it (afaict because they didnt like the dumb no-root rule) - that is never going to work out of the box - struggling to understand how it would work for anyone that said - fix should be pretty easy |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
@tsaarni with some warnings (not sure how important), and using the pr version, this kinda works would be good to know if what it produces is what we want |
|
Is the correct way to run this Full log is here https://gist.github.com/tsaarni/53dbc62dcebb13777d6f3039b7940a9a |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
No description provided.