Skip to content

protos: fix markdown links - #47131

Open
kyessenov wants to merge 4 commits into
envoyproxy:mainfrom
kyessenov:doc_md
Open

protos: fix markdown links#47131
kyessenov wants to merge 4 commits into
envoyproxy:mainfrom
kyessenov:doc_md

Conversation

@kyessenov

Copy link
Copy Markdown
Contributor

Change-Id: Ib18589e437f409bbcda14694b1277d4066c1ecde
Commit Message: Asked AI to convert markdown links to RST links which render nicer.
Additional Description:
Risk Level: no
Testing: no
Docs Changes: yes
Release Notes: no
Platform Specific Features: no

@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #47131 was opened by kyessenov.

see: more, trace.

Change-Id: Ib18589e437f409bbcda14694b1277d4066c1ecde
Signed-off-by: Kuat Yessenov <kuat@google.com>
phlax
phlax previously approved these changes Sep 2, 2026

@phlax phlax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @kyessenov

we probably want some linter to catch these

@phlax phlax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it fails rst parsing

you cant have 2 anon links on same page with same text - so in this case "here" is clashing

you can kinda workaround but it by adding an extra _ after each of the offending refs or better dont use "here" as link text


// The SXG response payload is Merkle Integrity Content Encoding (MICE) encoded (specification is [here](https://datatracker.ietf.org/doc/html/draft-thomson-http-mice-03))
// The SXG response payload is Merkle Integrity Content Encoding (MICE) encoded (specification is
// `here <https://datatracker.ietf.org/doc/html/draft-thomson-http-mice-03>`_)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// `here <https://datatracker.ietf.org/doc/html/draft-thomson-http-mice-03>`_)
// `here <https://datatracker.ietf.org/doc/html/draft-thomson-http-mice-03>`__)

Change-Id: Ie66169efd10b8ace91b08bedfb0e1b9d7c6472e4
Signed-off-by: Kuat Yessenov <kuat@google.com>
Change-Id: Ia3f072fa83c01d65e42ba95c94692b2c0161cd14
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
kyessenov enabled auto-merge (squash) September 2, 2026 21:30
Change-Id: I66334cbd0e27bc9f8fd15d5558bf75e8f545f512
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants