Refactored Android support to use EncryptedSharedPreferences. This el… - #103
Refactored Android support to use EncryptedSharedPreferences. This el…#103kito99 wants to merge 1 commit into
Conversation
…iminates unnecessary encryption code and resolves crashes we saw on several Android 12 and 13 devices.
|
In order to use this, you have to exclude the Native Biometric shared preferences file from backups: In <manifest ...>
<application
...
android:fullBackupContent="@xml/backup_rules">
</application>
</manifest>
<full-backup-content>
<include domain="sharedpref" path="."/>
<exclude domain="sharedpref" path="NativeBiometricSharedPreferences"/>
</full-backup-content> |
|
@kito99 - Do you think this PR would fix the issue we are seeing in Cap-go#7. If so would you mind opening this code change against the Cap-Go plugin which is being maintained by the Cap-Go team. Our company is also sponsoring a bounty on the issue so you would get paid for the work you've done here |
|
@danbunkr sure, I'll do that ASAP. |
|
@kito99 slammed into this issue last week/weekend. Thank you for your work on this PR. |
|
Same question - when will this be available? We think this fixes a current fairly wide spread issue that we're facing. |
|
Hey guys, I’ll try to get to it this weekend.
…On Dec 8, 2023 at 7:36 AM -0500, Nathan Douds ***@***.***>, wrote:
Same question - when will this be available? We think this fixes a current fairly wide spread issue that we're facing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Is @jmartinezehp or anyone else on this project available to review? @AdlerJS do you still want this applied to your fork? |
|
@kito99 thanks again for your effort on this. Does this mean Android support has returned? |
|
@BenRacicot afaik this PR fixes issues with Android support (we are using it in production). However, unless @AdlerJS still wants this PR on their fork, or the original maintainers like @jmartinezehp want the PR, there's not much I can do. We do have a fork that includes this PR available here: https://github.com/virtua-tech/capacitor-native-biometric. However, that's not necessarily a longterm option. |
Refactored Android support to use EncryptedSharedPreferences. This eliminates unnecessary encryption code and resolves crashes we saw on several Android 12 and 13 devices.
More info about EncryptedSharedPreferences: https://developer.android.com/reference/androidx/security/crypto/EncryptedSharedPreferences. Note the example uses https://developer.android.com/jetpack/androidx/releases/security 1.0, not 1.1 alpha (which is used for the code example on this page.)
This has been tested on several real devices using Android 10-13.