Additional tests - #307
Closed
joseph-palmer wants to merge 2 commits into
Closed
Conversation
|
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
Thank you again for the contribution. If making large scale changes consider using our |
8 tasks
Contributor
|
I imagine this has some conflicts with recent package changes? Should we pause on this for now and or pull the code out elsewhere? It might be worth having a little think about data integrity checks in general (i.e a validate check of a data source separate from "unit" testing etc). It would be nice to increase data specific testing. Same goes for #312. |
40 tasks
|
This PR has been flagged as stale due to lack of activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This Branch acts as a place to merge PRs for additional tests (listed in #302). If you are working on a test please write your name next to it on the checklist with the pr number for it.
To get started I have added tests that region names are not all NA.
closes #302