[AI-Assisted] feat(dynamics): close built-in capability audit - #3397
Merged
Conversation
This was referenced Sep 1, 2026
EvenSol
marked this pull request as ready for review
September 1, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advances #3298 WS6 (capability audit closure) under the frozen capability contract.
ProcessElementInterfacedeclaration ofrunTransient(double, UUID)by owned state;DynamicCapabilityReport.isFullyAudited();neqsim-dynamic-simulationguidance.Exact-head and capacity record
master@74c6a3125bdd1f646e7c24921d94b1cc2dfecfb6d6e2285e717c5bc649080119da70c3effdf84c94ai/3298-dynamic-capability-auditmasteradvanced after the contract only through the already-audited, non-overlapping refinery PR #3392. This branch deliberately preserves the frozen exact base; it was not rebased or force-updated.State-ownership audit
These labels describe state ownership only. They do not promote numerical, benchmark, safety, controls, line-pack, severe-slugging, or liquid-rich maturity. In particular,
PipeBeggsAndBrillsremains explicitly unqualified for conservative storage/line-pack claims; those studies remain routed to the qualifiedTwoFluidPipepath and the unresolved WS1/WS2 gates.Validation
Passed on the exact submitted tree:
python devtools/run_spotless.py applypython devtools/run_spotless.py checkbash devtools/run_spotless.sh applybash devtools/run_spotless.sh checkpython devtools/check_documentation_search.pyDynamicCapabilityBuiltInInventoryTest,DynamicCapabilityReportTest,DynamicCapabilityModuleContainerTest,DynamicActivationReportTest,PressureFlowDynamicCapabilityTestControlsBenchmarkSuiteTest,AgentBenchmarkSuiteTest,SevereSluggingExperimentalBenchmarkTest,SevereSluggingBenchmarkHarnessTest,TwoFluidPipeTransientNullTest,CoupledPressureMomentumTengesdalProgressTestThe local
pre-commitexecutable/module is unavailable, so its configured Spotless and documentation-search hooks were executed directly and passed. An optional full-DskipITs testrun progressed without observed failures through the dynamic, distillation,TwoFluidPipe, water-hammer, and terrain/network groups, then was stopped at the campaign fast-validation budget; exact-head draft CI is authoritative for the remaining repository breadth.Documentation impact
Updated:
docs/process/dynamic-capability-contract.md.github/skills/neqsim-dynamic-simulation/SKILL.mdThe docs distinguish full inventory audit from strict runtime preflight and quantitative/public-benchmark qualification.
Frozen stop boundary
No transient equations, solver/IMEX/outlet boundary, regime map, closure, activation policy, benchmark data, or runtime equipment behavior changed. No commercial trace was used. WS1, WS2, WS4, and final routing/qualification work remain open in #3298.
Draft only. Do not mark ready, merge, rebase, force-push, close, replace, or abandon for capacity reasons.