Skip to content

Commit 00ef892

Browse files
committed
Fix the Docker verify step running build.sh instead of bash
The Dockerfile sets ENTRYPOINT ["/opt/neuros/build.sh"], so `docker run neuros-build bash -c '...'` passed 'bash -c ...' to build.sh as arguments. build.sh then attempted a real ISO build inside the container and died on 'sudo: command not found', failing the job every time. Pass --entrypoint bash so the verification actually runs. Also drops the `|| echo "Docker build skipped"` on the build step: it turned a broken Dockerfile into a confusing downstream failure instead of reporting itself. Verified locally — the image builds and reports Python 3.12.3 and 78 tools.
1 parent 1bdeec6 commit 00ef892

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,12 @@ jobs:
105105
uses: docker/setup-buildx-action@v3
106106

107107
- name: Build Docker image
108-
run: docker build -t neuros-build . 2>&1 || echo "Docker build skipped (non-critical in CI)"
108+
run: docker build -t neuros-build .
109109

110-
- name: Verify Docker image (if built)
110+
- name: Verify Docker image
111111
run: |
112-
if docker image inspect neuros-build >/dev/null 2>&1; then
113-
docker run --rm neuros-build bash -c "
114-
echo 'Container verified:'
115-
python3 --version 2>&1 || echo 'Python: not found'
116-
echo 'NeurOS tools:' \$(find /usr/local/bin -name 'neuros-*' 2>/dev/null | wc -l)
117-
"
118-
else
119-
echo "Docker image not built — check Dockerfile"
120-
fi
112+
docker run --rm --entrypoint bash neuros-build -c "
113+
echo 'Container verified:'
114+
python3 --version
115+
echo 'NeurOS tools:' \$(find /usr/local/bin -name 'neuros-*' | wc -l)
116+
"

0 commit comments

Comments
 (0)