Skip to content

Commit 9e72e0f

Browse files
committed
chore(deps): bump base64 from 0.22.1 to 0.23.0 without simd-unsafe
base64 0.23.0 adds `simd-unsafe` to its default features, which disables the crate's unconditional `#![forbid(unsafe_code)]`. Our call sites only ever build the scalar `GeneralPurpose` engine, and that engine passes a no-op SIMD prefix, so the SIMD engines are unreachable from here. Turning the default features off keeps the dependency free of unsafe code and leaves the API we use unchanged. ureq, termwiz and tungstenite still require base64 0.22.1, so both locks carry two versions of the crate.
1 parent 4afedda commit 9e72e0f

3 files changed

Lines changed: 26 additions & 12 deletions

File tree

Cargo.lock

Lines changed: 10 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ sha2 = "0.10"
3838
hmac = "0.12"
3939
quick-xml = { version = "0.41", features = ["serde", "serialize"] }
4040
rsa = { version = "0.9", features = ["sha2"] }
41-
base64 = "0.22"
41+
# default-features off drops the `simd-unsafe` feature, keeping base64 at
42+
# `#![forbid(unsafe_code)]`. We only ever use the scalar GeneralPurpose engine.
43+
base64 = { version = "0.23", default-features = false, features = ["std"] }
4244
libc = "0.2"
4345
log = "0.4"
4446
simplelog = "0.12"

fuzz/Cargo.lock

Lines changed: 13 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)