Repository navigation
Run the SSMS restore step under pwsh with per-command exit checks (#655) - #657
Merged
Merged
Conversation
The first dev run of the two-job workflow (38660830104) failed at "Restore SSMS projects" with "msbuild: command not found". The round-1 review had switched the step to bash so the first failing restore would fail the step, but the msbuild folder that setup-msbuild adds to PATH does not reach a bash step on the Windows runner. It did reach the pwsh step in the green run before that change. The step runs under pwsh again, and each restore checks $LASTEXITCODE so a failure in the first or second command still fails the step. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MrD9SGvLFx4kJaeGZyXG9
|
Reviewed the diff: a single workflow step switched to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first dev run of the two-job dependency submission workflow from #656, run 38660830104, failed at the
Restore SSMS projectsstep:The
submitjob was skipped, so dev got no snapshot from that run.Cause
The round-1 review of #656 switched that step to
shell: bashso the first failing restore would fail the step (pwsh only reports the last command's exit code). On the Windows runner the msbuild folder thatmicrosoft/setup-msbuildadds to PATH reaches pwsh steps but not bash steps. The green run before that change (38657114293) ran the step under pwsh.Change
One step in
.github/workflows/dependency-submission.yml:shell: pwshinstead ofshell: bash.if ($LASTEXITCODE) { exit $LASTEXITCODE }, so a failure in the first or second command still fails the step.Nothing else in the workflow changes. The
submitjob, the snapshot script and the artifact handling are untouched.Verification
detectandsubmitboth green, and the submit log printsresult: ACCEPTED(dev is not the default branch, so GitHub accepts the snapshot without using it for alerts).Refs #655.
🤖 Generated with Claude Code
https://claude.ai/code/session_018MrD9SGvLFx4kJaeGZyXG9