Repository navigation
Release SSMS step: match NuGet audit diagnostics, not bare codes - #668
Merged
Merged
Conversation
…ild step Directory.Build.props puts NU1903;NU1904 in WarningsAsErrors (#654), so MSBuild passes them to csc as /warnaserror+:...NU1903,NU1904 and the bare-code pattern matched the compiler command line. v1.31.0's release run (39448831126) raised a false "SSMS restore failed the NuGet audit" warning from it; that log has no real NU1903/NU1904 diagnostic. The pattern now requires 'warning NU190x:' or 'error NU190x:'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoaQ2xKMpZEXvm4HncT8ND
|
Reviewed: the narrowed pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.31.0's release run (39448831126) raised
SSMS restore failed the NuGet audit, quoting the csc command line. It was a false alarm.NU1903;NU1904inWarningsAsErrors(rootDirectory.Build.props), so MSBuild passes them to csc as/warnaserror+:...NU1903,NU1904.warning NU190x:orerror NU190x:line.The pattern is now
(warning|error) NU190[34]:. Checked with PowerShellSelect-Stringagainst the downloaded step log: the old pattern hits 2 non-echo lines, the new one hits 0. On sample lines, the new one matches... : warning NU1903: Package ...and... : error NU1904: ..., and skipscsc.exe /warnaserror+:NU1605,NU1903,NU1904.One file, three lines (two of them a comment). The release workflow runs only on a dev -> main merge, so the next release is its first run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UoaQ2xKMpZEXvm4HncT8ND