Skip to content

Bring CredentialManager and HangDump up to date and null-guard the MCP smoke test (#671) - #672

Merged
erikdarlingdata merged 1 commit into
devfrom
fix/671-package-bumps
Oct 29, 2026
Merged

erikdarlingdata merged 1 commit into
devfrom
fix/671-package-bumps

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Claude posting for Erik Darling.

Refs #671.

What changes

  • Directory.Packages.props: Meziantou.Framework.Win32.CredentialManager 3.0.7 -> 3.0.8, Microsoft.Testing.Extensions.HangDump 2.5.1 -> 2.5.2, Microsoft.AspNetCore.Components.WebAssembly and its DevServer 10.0.13 -> 10.0.14 (the same-major sweep found only these two extra; every other package is already on its newest stable in its major).
  • tests/PlanViewer.Core.Tests/McpSmokeTests.cs:50: client.ServerInfo.Name -> client.ServerInfo?.Name. ModelContextProtocol 2.3.0 made McpClient.ServerInfo nullable, so a null now fails the assertion instead of throwing NullReferenceException. This was the only use of the property outside McpHostService (which sets it); the builds show no CS8602 or other new warning.

Left on their majors on purpose: MessagePack (2.5.307; 3.x exists), SkiaSharp.NativeAssets.Linux (3.119.4; 4.x exists), Microsoft.VSSDK.BuildTools (17.14.2142; 18.x exists).

Release notes

  • HangDump / Microsoft.Testing.Platform 2.5.2 (testfx Changelog-Platform): no breaking changes and no HangDump items. Notes: startup work reduced, Azure DevOps attachment limit raised, MessagePack dependency 3.1.11, assorted fixes.
  • Meziantou.Framework.Win32.CredentialManager 3.0.8: the repo publishes no release notes; this is a patch bump and the credential tests pass.
  • Microsoft.AspNetCore.Components.WebAssembly 10.0.14: servicing patch of the same major; PlanViewer.Web builds clean.

Test plan

  • PlanViewer.App Debug build: 0 Warning(s), 0 Error(s)
  • PlanViewer.Core.Tests Debug build: 0 Warning(s), 0 Error(s)
  • PlanViewer.Web Debug build (uses the WebAssembly bump): 0 Warning(s), 0 Error(s)
  • McpSmokeTests: Total 2, Failed 0
  • *Credential* classes (credential storage): Total 34, Failed 0, Skipped 29 (the keychain tests skip on this Windows machine)
  • Full suite and the other test projects (Ssms.Installer.Tests also references HangDump): pending CI. Not run on this laptop.

Builds started while the laptop read 94-98 C (the thermal cap held for 15 minutes with no drop below 95 C, then I proceeded; cpucap throttled the builds).

Considered, not added

  • The 2.3.0 note that HTTP responses wait for the first protocol message before sending headers: no Studio MCP tool is known to run silently for longer than a client's HTTP timeout (the tools were not audited one by one in this lane), so nothing was changed.

@erikdarlingdata
erikdarlingdata marked this pull request as ready for review October 29, 2026 13:50
@claude

claude Bot commented Oct 29, 2026

Copy link
Copy Markdown

Reviewed the diff: patch-level bumps in Directory.Packages.props plus a null-conditional in McpSmokeTests. I found no correctness, untrusted-input, or convention problems. No version-file changes are needed, since nothing here touches <Version> or the SSMS manifest. The null-guard makes a null ServerInfo fail the assertion instead of throwing a NullReferenceException. The full suite and Ssms.Installer.Tests are still pending CI, so check those before merging.

@erikdarlingdata
erikdarlingdata merged commit fb2adb1 into dev Oct 29, 2026
5 checks passed
@erikdarlingdata
erikdarlingdata deleted the fix/671-package-bumps branch October 29, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant