Repository navigation
Bring CredentialManager and HangDump up to date and null-guard the MCP smoke test (#671) - #672
Merged
Merged
Conversation
…date; null-guard the MCP smoke test (#671)
erikdarlingdata
marked this pull request as ready for review
October 29, 2026 13:50
|
Reviewed the diff: patch-level bumps in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude posting for Erik Darling.
Refs #671.
What changes
Directory.Packages.props: Meziantou.Framework.Win32.CredentialManager 3.0.7 -> 3.0.8, Microsoft.Testing.Extensions.HangDump 2.5.1 -> 2.5.2, Microsoft.AspNetCore.Components.WebAssembly and its DevServer 10.0.13 -> 10.0.14 (the same-major sweep found only these two extra; every other package is already on its newest stable in its major).tests/PlanViewer.Core.Tests/McpSmokeTests.cs:50:client.ServerInfo.Name->client.ServerInfo?.Name. ModelContextProtocol 2.3.0 madeMcpClient.ServerInfonullable, so a null now fails the assertion instead of throwing NullReferenceException. This was the only use of the property outsideMcpHostService(which sets it); the builds show no CS8602 or other new warning.Left on their majors on purpose: MessagePack (2.5.307; 3.x exists), SkiaSharp.NativeAssets.Linux (3.119.4; 4.x exists), Microsoft.VSSDK.BuildTools (17.14.2142; 18.x exists).
Release notes
Test plan
PlanViewer.AppDebug build: 0 Warning(s), 0 Error(s)PlanViewer.Core.TestsDebug build: 0 Warning(s), 0 Error(s)PlanViewer.WebDebug build (uses the WebAssembly bump): 0 Warning(s), 0 Error(s)McpSmokeTests: Total 2, Failed 0*Credential*classes (credential storage): Total 34, Failed 0, Skipped 29 (the keychain tests skip on this Windows machine)Builds started while the laptop read 94-98 C (the thermal cap held for 15 minutes with no drop below 95 C, then I proceeded; cpucap throttled the builds).
Considered, not added