Skip to content

Commit ed59721

Browse files
Copilotneilime
andcommitted
Fix build and tests: resolve TypeScript error and add missing test file
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
1 parent b883018 commit ed59721

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

packages/core/src/services/PackageManagerService.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { existsSync, writeFileSync } from "fs";
1+
import { existsSync, unlinkSync, writeFileSync } from "fs";
22
import { safeExec } from "../tests/cli";
33
import { createProjectForTestFile, deleteTestProject } from "../tests/test-project";
44
import { PackageJson } from "./PackageJson";
@@ -33,6 +33,15 @@ describe("PackageManagerService", () => {
3333
});
3434

3535
it("should throws an error when no package manager is detectable", () => {
36+
// Remove all lock files to ensure no package manager is detected
37+
const lockFiles = ['package-lock.json', 'yarn.lock', 'pnpm-lock.yaml'];
38+
lockFiles.forEach(lockFile => {
39+
const lockFilePath = `${testProjectDir}/${lockFile}`;
40+
if (existsSync(lockFilePath)) {
41+
unlinkSync(lockFilePath);
42+
}
43+
});
44+
3645
expect(() => {
3746
PackageManagerService.detectPackageManager(testProjectDir);
3847
}).toThrow(`Could not detect package manager in directory: ${testProjectDir}. No lock file found.`);

packages/core/src/services/PackageManagerService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export class PackageManagerService {
101101
static async isPackageInstalled(packageName: string, dirPath: string): Promise<boolean> {
102102
const packageManager = PackageManagerService.detectPackageManager(dirPath);
103103

104-
const args: string[] = [packageManager, "list", "--depth=1", "--json"];
104+
let args: string[] = [packageManager, "list", "--depth=1", "--json"];
105105

106106
switch (packageManager) {
107107
case PackageManagerType.yarn:

packages/react/__tests__/test-project/package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)